Bug 35829 - Web Inspector: switching to/from Timeline Panel moves scrolled region.
Summary: Web Inspector: switching to/from Timeline Panel moves scrolled region.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2010-03-06 09:36 PST by Pavel Feldman
Modified: 2010-03-06 11:51 PST (History)
5 users (show)

See Also:

[PATCH] Proposed fix. (5.59 KB, patch)
2010-03-06 09:39 PST, Pavel Feldman
jorlow: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-03-06 09:36:33 PST
The reason is that when switching back, sidebar tree is the default focus target, but has random scroll offset. The only solution i've found is to 1) prevent scroller from being default focus target 2) manually restore scroll offset upon show. Only (1) or only (2) does not work for the reason above.
Comment 1 Pavel Feldman 2010-03-06 09:39:39 PST
Created attachment 50153 [details]
[PATCH] Proposed fix.
Comment 2 Pavel Feldman 2010-03-06 10:02:34 PST
I'd like to land this soon for the nightly / dev channel. So I am asking for formal reviewer from somebody. I'll make sure this is fine with Tim (xenon) who was reviewing my timeline code. This change was tested well and is safe. Brings only good :)
Comment 3 Jeremy Orlow 2010-03-06 10:02:37 PST
Comment on attachment 50153 [details]
[PATCH] Proposed fix.

Seems reasonable.  r=me
Comment 4 Pavel Feldman 2010-03-06 10:15:09 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/English.lproj/localizedStrings.js
	M	WebCore/inspector/front-end/TimelinePanel.js
Committed r55627
Comment 5 Timothy Hatcher 2010-03-06 11:51:23 PST
Looks fine.