Bug 35822 - webkit-patch land fails if not run from the root directory
Summary: webkit-patch land fails if not run from the root directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-05 17:09 PST by Eric Seidel (no email)
Modified: 2010-03-31 20:50 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2010-03-31 20:45 PDT, Eric Seidel (no email) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-03-05 17:09:51 PST 
webkit-patch land fails if not run from the root directory

Parsing ChangeLog: LayoutTests/ChangeLog
Traceback (most recent call last):
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkit-patch", line 109, in <module>
    WebKitPatch().main()
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 299, in main
    return command.check_arguments_and_execute(options, args, self)
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 113, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/commands/abstractsequencedcommand.py", line 43, in execute
    self._sequence.run_and_handle_errors(tool, options, self._prepare_state(options, args, tool))
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/stepsequence.py", line 66, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/stepsequence.py", line 60, in _run
    step(tool, options).run(state)
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/steps/commit.py", line 34, in run
    commit_message = self._tool.scm().commit_message_for_this_commit()
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/scm.py", line 181, in commit_message_for_this_commit
    changelog_entry = ChangeLog(changelog_path).latest_entry()
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/webkitpy/changelogs.py", line 73, in latest_entry
    changelog_file = open(self.path)
IOError: [Errno 2] No such file or directory: 'LayoutTests/ChangeLog'

I feel like this used to work fine.
Comment 1 Chris Jerdonek 2010-03-08 03:02:20 PST 
(In reply to comment #0)
> webkit-patch land fails if not run from the root directory
> 
> <snip>
> 
> I feel like this used to work fine.

check-webkit-style used to have this problem, too:

https://bugs.webkit.org/show_bug.cgi?id=33791
Comment 2 Eric Seidel (no email) 2010-03-31 20:45:49 PDT 
Created attachment 52250 [details]
Patch
Comment 3 Adam Barth 2010-03-31 20:47:40 PDT 
Comment on attachment 52250 [details]
Patch

yay!
Comment 4 Eric Seidel (no email) 2010-03-31 20:50:06 PDT 
Somehow we got a second parsing changlog message.

Parsing ChangeLog: /Projects/WebKit/WebKitTools/ChangeLog
Fetching: https://bugs.webkit.org/show_bug.cgi?id=35822&ctype=xml
Guessing "Adam Barth" as reviewer from attachment 52250 [details] on bug 35822.
Parsing ChangeLog: /Projects/WebKit/WebKitTools/ChangeLog

It's slightly lame that it gives the full path now.
Comment 5 Eric Seidel (no email) 2010-03-31 20:50:10 PDT 
Committed r56891: <http://trac.webkit.org/changeset/56891>