Bug 35794 - [Qt] QtLauncher need a menu option to show/hide FPS
Summary: [Qt] QtLauncher need a menu option to show/hide FPS
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Enhancement
Assignee: QtWebKit Unassigned
Keywords: Qt
Depends on:
Reported: 2010-03-05 09:56 PST by Jesus Sanchez-Palencia
Modified: 2010-03-13 01:38 PST (History)
2 users (show)

See Also:

Patch (2.15 KB, patch)
2010-03-05 09:58 PST, Jesus Sanchez-Palencia
hausmann: review+
eric: commit-queue-
Details | Formatted Diff | Diff
Add Show FPS option to QtLauncher (2.76 KB, patch)
2010-03-12 12:28 PST, Jesus Sanchez-Palencia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesus Sanchez-Palencia 2010-03-05 09:56:28 PST
[Qt] QtLauncher need a menu option to show/hide FPS
Comment 1 Jesus Sanchez-Palencia 2010-03-05 09:58:10 PST
Created attachment 50101 [details]
Comment 2 Eric Seidel (no email) 2010-03-05 12:28:54 PST
Comment on attachment 50101 [details]

This patch does not apply, thus it can't be commit-queue'd.

Since when do browsers have an fps? :)
Comment 3 Simon Hausmann 2010-03-06 23:34:02 PST
Comment on attachment 50101 [details]

Apart from the commit queue problem the patch looks good to me (I've been looking for this option, too :)

I think in general it would be good to replace all the commandline options of QtLauncher with menus actions.
Comment 4 Jesus Sanchez-Palencia 2010-03-08 09:56:23 PST
(In reply to comment #3)

There was a problem with the patches order, I guess. I'll fix this as soon as I'm back from Bossa conference (in 4 days).

thanks for the review!
Comment 5 Tor Arne Vestbø 2010-03-10 06:43:50 PST
Please follow the QtWebKit bug reporting guidelines when reporting bugs.

See http://trac.webkit.org/wiki/QtWebKitBugs


  - The 'QtWebKit' component should only be used for bugs/features in the
    public QtWebKit API layer, not to signify that the bug is specific to
    the Qt port of WebKit


  - Add the keyword 'Qt' to signal that it's a Qt-related bug

Comment 6 Jesus Sanchez-Palencia 2010-03-12 12:28:22 PST
Created attachment 50622 [details]
Add Show FPS option to QtLauncher 

Comment 7 WebKit Commit Bot 2010-03-13 01:38:10 PST
Comment on attachment 50622 [details]
Add Show FPS option to QtLauncher 

Clearing flags on attachment: 50622

Committed r55956: <http://trac.webkit.org/changeset/55956>
Comment 8 WebKit Commit Bot 2010-03-13 01:38:15 PST
All reviewed patches have been landed.  Closing bug.