Bug 35794 – [Qt] QtLauncher need a menu option to show/hide FPS

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jesus Sanchez-Palencia]

[Qt] QtLauncher need a menu option to show/hide FPS

[Jesus Sanchez-Palencia]

Created attachment 50101 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 50101 [details]
Patch

This patch does not apply, thus it can't be commit-queue'd.

Since when do browsers have an fps? :)

[Simon Hausmann]

Comment on attachment 50101 [details]
Patch

Apart from the commit queue problem the patch looks good to me (I've been looking for this option, too :)

I think in general it would be good to replace all the commandline options of QtLauncher with menus actions.

[Jesus Sanchez-Palencia]

(In reply to comment #3)

There was a problem with the patches order, I guess. I'll fix this as soon as I'm back from Bossa conference (in 4 days).

thanks for the review!

[Tor Arne Vestbø]

Please follow the QtWebKit bug reporting guidelines when reporting bugs.

See http://trac.webkit.org/wiki/QtWebKitBugs

Specifically:

  - The 'QtWebKit' component should only be used for bugs/features in the
    public QtWebKit API layer, not to signify that the bug is specific to
    the Qt port of WebKit

      http://trac.webkit.org/wiki/QtWebKitBugs#Component

  - Add the keyword 'Qt' to signal that it's a Qt-related bug

      http://trac.webkit.org/wiki/QtWebKitBugs#Keywords

[Jesus Sanchez-Palencia]

Created attachment 50622 [details]
Add Show FPS option to QtLauncher 

Fixed.

[WebKit Commit Bot]

Comment on attachment 50622 [details]
Add Show FPS option to QtLauncher 

Clearing flags on attachment: 50622

Committed r55956: <http://trac.webkit.org/changeset/55956>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.