Bug 35789 – OSX: Implement 'preload=none'

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

https://bugs.webkit.org/show_bug.cgi?id=35385 added support for the 'preload' attribute to the media element. That patch only dealt with parsing the attribute and passing it down to the media engine, actually making it work requires support in the media engine. This bug is for the work in the OSX media engine.

[Eric Carlson]

Created attachment 50095 [details]
Proposed patch.

[Adele Peterson]

Comment on attachment 50095 [details]
Proposed patch.

> @@ -746,7 +775,7 @@ bool MediaPlayerPrivate::hasAudio() cons
>  bool MediaPlayerPrivate::supportsFullscreen() const
>  {
>  #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
> -    return true;
> +    return metaDataAvailable();
>  #else
>      // See <rdar://problem/7389945>
>      return false;

I don't think this change is covered in the ChangeLog - is this related?

[Eric Carlson]

(In reply to comment #2)
> (From update of attachment 50095 [details])
> > @@ -746,7 +775,7 @@ bool MediaPlayerPrivate::hasAudio() cons
> >  bool MediaPlayerPrivate::supportsFullscreen() const
> >  {
> >  #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
> > -    return true;
> > +    return metaDataAvailable();
> >  #else
> >      // See <rdar://problem/7389945>
> >      return false;
> 
> I don't think this change is covered in the ChangeLog - is this related?

Oops, that is for another bug.

[Adele Peterson]

Comment on attachment 50095 [details]
Proposed patch.

ok- r=me minus that part of the patch.

[Eric Carlson]

http://trac.webkit.org/changeset/55587