Bug 35789 - OSX: Implement 'preload=none'
Summary: OSX: Implement 'preload=none'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-05 07:24 PST by Eric Carlson
Modified: 2010-03-05 14:25 PST (History)
0 users

See Also:


Attachments
Proposed patch. (13.59 KB, patch)
2010-03-05 07:26 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2010-03-05 07:24:24 PST
https://bugs.webkit.org/show_bug.cgi?id=35385 added support for the 'preload' attribute to the media element. That patch only dealt with parsing the attribute and passing it down to the media engine, actually making it work requires support in the media engine. This bug is for the work in the OSX media engine.
Comment 1 Eric Carlson 2010-03-05 07:26:50 PST
Created attachment 50095 [details]
Proposed patch.
Comment 2 Adele Peterson 2010-03-05 08:52:55 PST
Comment on attachment 50095 [details]
Proposed patch.

> @@ -746,7 +775,7 @@ bool MediaPlayerPrivate::hasAudio() cons
>  bool MediaPlayerPrivate::supportsFullscreen() const
>  {
>  #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
> -    return true;
> +    return metaDataAvailable();
>  #else
>      // See <rdar://problem/7389945>
>      return false;

I don't think this change is covered in the ChangeLog - is this related?
Comment 3 Eric Carlson 2010-03-05 08:55:14 PST
(In reply to comment #2)
> (From update of attachment 50095 [details])
> > @@ -746,7 +775,7 @@ bool MediaPlayerPrivate::hasAudio() cons
> >  bool MediaPlayerPrivate::supportsFullscreen() const
> >  {
> >  #if !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
> > -    return true;
> > +    return metaDataAvailable();
> >  #else
> >      // See <rdar://problem/7389945>
> >      return false;
> 
> I don't think this change is covered in the ChangeLog - is this related?

Oops, that is for another bug.
Comment 4 Adele Peterson 2010-03-05 09:04:47 PST
Comment on attachment 50095 [details]
Proposed patch.

ok- r=me minus that part of the patch.
Comment 5 Eric Carlson 2010-03-05 09:14:55 PST
http://trac.webkit.org/changeset/55587