RESOLVED FIXED 35774
[DRT/Chromium] Add AccessibilityController.{cpp,h} and AccessibilityUIElement.{cpp,h} 
https://bugs.webkit.org/show_bug.cgi?id=35774
Summary [DRT/Chromium] Add AccessibilityController.{cpp,h} and AccessibilityUIElement...
Kent Tamura
Reported 2010-03-04 17:22:30 PST
[DRT/Chromium] Add AccessibilityController.{cpp,h} and AccessibilityUIElement.{cpp,h}
Attachments
Proposed patch (36.65 KB, patch)
2010-03-04 17:28 PST, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Proposed patch rev.2 (style fixes) (36.64 KB, patch)
2010-03-04 17:36 PST, Kent Tamura 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2010-03-04 17:28:51 PST
Created attachment 50069 [details] Proposed patch
WebKit Review Bot
Comment 2 2010-03-04 17:30:07 PST
Attachment 50069 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:260: Place brace on its own line for function definitions. [whitespace/braces] [4] WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:481: One line control clauses should not use braces. [whitespace/braces] [4] WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:515: One space before end of line comments [whitespace/comments] [5] WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:522: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:559: Place brace on its own line for function definitions. [whitespace/braces] [4] WebKitTools/DumpRenderTree/chromium/AccessibilityUIElement.cpp:563: Place brace on its own line for function definitions. [whitespace/braces] [4] WebKitTools/DumpRenderTree/chromium/AccessibilityController.cpp:44: Place brace on its own line for function definitions. [whitespace/braces] [4] WebKitTools/DumpRenderTree/chromium/AccessibilityController.h:35: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 8 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kent Tamura
Comment 3 2010-03-04 17:36:55 PST
Created attachment 50071 [details] Proposed patch rev.2 (style fixes)
Dimitri Glazkov (Google)
Comment 4 2010-03-07 18:47:07 PST
Comment on attachment 50071 [details] Proposed patch rev.2 (style fixes) ok.
Kent Tamura
Comment 5 2010-03-07 20:25:04 PST
Thanks. I'll remove TODO(name) comments before landing.
Kent Tamura
Comment 6 2010-03-07 21:03:15 PST
Landed as r55655.
Note You need to log in before you can comment on or make changes to this bug.