Bug 35771 – [chromium] WebDocument:applicationID() crashes on <meta> tag with no http-equiv attribute

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[John Gregg]

if all the other checks fail, and there is a meta tag with no http-equiv attribute, the code calls .lower() on null.

see also http://code.google.com/p/chromium/issues/detail?id=34961 for repro steps using chrome.

[John Gregg]

Created attachment 50061 [details]
patch

[WebKit Review Bot]

Attachment 50061 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/WebDocument.cpp:152:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[John Gregg]

Created attachment 50062 [details]
fix style warning

[Darin Fisher (:fishd, Google)]

Comment on attachment 50062 [details]
fix style warning

Can we please just remove WebDocument::applicationID.  As I mentioned to Aaron,
it doesn't belong here and can be implemented purely in terms of WebKit APIs.

[Darin Fisher (:fishd, Google)]

Comment on attachment 50062 [details]
fix style warning

> Index: WebKit/chromium/src/WebDocument.cpp
> +        if (element->hasAttribute("http-equiv")
> +            && element->getAttribute("http-equiv").lower() == kChromeApplicationHeader) {
>              return element->getAttribute("value");
>          }

nit: there should be no brackets around single line statements

[Aaron Boodman]

Darin, I knew you'd say that.

I am going to start pulling it out soon. Can johnnyg just fix this immediate
issue in the meantime?

[John Gregg]

Because notifications are hooked up to applicationID() already, this is causing real crashes when people use notifications... so i'd rather not wait for a large refactor to fix that.

[John Gregg]

Created attachment 50065 [details]
removing {}s

well I didn't put the braces there but I can remove them...

[Darin Fisher (:fishd, Google)]

Sorry to give you a hard time about the applicationID thing.  I would have r+'d the patch before if it didn't have the style issue.

[WebKit Commit Bot]

Comment on attachment 50065 [details]
removing {}s

Clearing flags on attachment: 50065

Committed r55571: <http://trac.webkit.org/changeset/55571>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.