RESOLVED WONTFIX 35761
New port: EFL; adding files to WebCore/plugins/efl (patch 1/2) 
https://bugs.webkit.org/show_bug.cgi?id=35761
Summary New port: EFL; adding files to WebCore/plugins/efl (patch 1/2)
Leandro Pereira
Reported 2010-03-04 12:02:03 PST
+++ This bug was initially created as a clone of Bug #35087 +++ Subject says it all.
Attachments
Add files to WebCore/plugins/efl (patch 1/2) (21.32 KB, patch)
2010-03-04 12:02 PST, Leandro Pereira 		no flags
DetailsFormatted DiffDiff
Add files to WebCore/plugins/efl (patch 1/2) (21.31 KB, patch)
2010-03-04 13:26 PST, Leandro Pereira 		zecke: review-
DetailsFormatted DiffDiff
Add files to WebCore/plugins/efl (patch 1/2) (21.66 KB, patch)
2010-03-10 09:26 PST, Leandro Pereira 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Leandro Pereira
Comment 1 2010-03-04 12:02:54 PST
Created attachment 50044 [details] Add files to WebCore/plugins/efl (patch 1/2)
WebKit Review Bot
Comment 2 2010-03-04 12:07:01 PST
Attachment 50044 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/plugins/efl/PluginViewEfl.cpp:39: Alphabetical sorting problem. [build/include_order] [4] WebCore/plugins/efl/PluginViewEfl.cpp:44: Alphabetical sorting problem. [build/include_order] [4] WebCore/plugins/efl/PluginViewEfl.cpp:53: Alphabetical sorting problem. [build/include_order] [4] WebCore/plugins/efl/PluginViewEfl.cpp:62: Alphabetical sorting problem. [build/include_order] [4] WebCore/plugins/efl/PluginPackageEfl.cpp:38: Alphabetical sorting problem. [build/include_order] [4] WebCore/plugins/efl/PluginPackageEfl.cpp:42: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 6 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Leandro Pereira
Comment 3 2010-03-04 13:26:10 PST
Created attachment 50047 [details] Add files to WebCore/plugins/efl (patch 1/2) Add revised patch, so it passes style-queue requirements.
Holger Freyther
Comment 4 2010-03-09 20:14:19 PST
Comment on attachment 50047 [details] Add files to WebCore/plugins/efl (patch 1/2) Upstream PLuginView code has changed, you should implement getPlatformValue and only for the attributes not handled in the common PluginView::getValue impl.
Leandro Pereira
Comment 5 2010-03-10 09:26:48 PST
Created attachment 50409 [details] Add files to WebCore/plugins/efl (patch 1/2) Updated patch.
Gustavo Sverzut Barbieri
Comment 6 2010-04-12 17:23:36 PDT
Please close this bug as we'll go with Plugin*None as requested by Zecke as soon as #37478 is done.
Leandro Pereira
Comment 7 2010-04-13 06:42:15 PDT
Closing this bug as we'll use the Plugin*None implementation until we have a better Plugin implementation.
Gustavo Noronha (kov)
Comment 8 2010-04-15 05:48:01 PDT
Comment on attachment 50409 [details] Add files to WebCore/plugins/efl (patch 1/2) Clearing flags.
Note You need to log in before you can comment on or make changes to this bug.