Bug 35761 - New port: EFL; adding files to WebCore/plugins/efl (patch 1/2)
Summary: New port: EFL; adding files to WebCore/plugins/efl (patch 1/2)
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-04 12:02 PST by Leandro Pereira
Modified: 2010-04-15 05:48 PDT (History)
12 users (show)

See Also:

Attachments
Add files to WebCore/plugins/efl (patch 1/2) (21.32 KB, patch)
2010-03-04 12:02 PST, Leandro Pereira 		no flags Details | Formatted Diff | Diff
Add files to WebCore/plugins/efl (patch 1/2) (21.31 KB, patch)
2010-03-04 13:26 PST, Leandro Pereira 		zecke: review-
Details | Formatted Diff | Diff
Add files to WebCore/plugins/efl (patch 1/2) (21.66 KB, patch)
2010-03-10 09:26 PST, Leandro Pereira 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leandro Pereira 2010-03-04 12:02:03 PST 
+++ This bug was initially created as a clone of Bug #35087 +++

Subject says it all.
Comment 1 Leandro Pereira 2010-03-04 12:02:54 PST 
Created attachment 50044 [details]
Add files to WebCore/plugins/efl (patch 1/2)
Comment 2 WebKit Review Bot 2010-03-04 12:07:01 PST 
Attachment 50044 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/plugins/efl/PluginViewEfl.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/plugins/efl/PluginViewEfl.cpp:44:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/plugins/efl/PluginViewEfl.cpp:53:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/plugins/efl/PluginViewEfl.cpp:62:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/plugins/efl/PluginPackageEfl.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/plugins/efl/PluginPackageEfl.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 6 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Leandro Pereira 2010-03-04 13:26:10 PST 
Created attachment 50047 [details]
Add files to WebCore/plugins/efl (patch 1/2)

Add revised patch, so it passes style-queue requirements.
Comment 4 Holger Freyther 2010-03-09 20:14:19 PST 
Comment on attachment 50047 [details]
Add files to WebCore/plugins/efl (patch 1/2)

Upstream PLuginView code has changed, you should implement getPlatformValue and only for the attributes not handled in the common PluginView::getValue impl.
Comment 5 Leandro Pereira 2010-03-10 09:26:48 PST 
Created attachment 50409 [details]
Add files to WebCore/plugins/efl (patch 1/2)

Updated patch.
Comment 6 Gustavo Sverzut Barbieri 2010-04-12 17:23:36 PDT 
Please close this bug as we'll go with Plugin*None as requested by Zecke as soon as #37478 is done.
Comment 7 Leandro Pereira 2010-04-13 06:42:15 PDT 
Closing this bug as we'll use the Plugin*None implementation until we have a better Plugin implementation.
Comment 8 Gustavo Noronha (kov) 2010-04-15 05:48:01 PDT 
Comment on attachment 50409 [details]
Add files to WebCore/plugins/efl (patch 1/2)

Clearing flags.