Bug 35760 – [Chromium] Adding Chromium -> WebCore touch type conversions

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Garret Kelly]

Adding platform event/point builders for the corresponding Chromium types.

[Garret Kelly]

Created attachment 50043 [details]
Initial patch

[Eric Seidel (no email)]

Comment on attachment 50043 [details]
Initial patch

Aren't PlatformTouchEvent used as stack objects?  They're not ref-counted, so I assume no one holds pointers to them.  In that case, virtual methods (like virtual destructors) make no sense!

This seems like the wrong model.  Normally Platform*Event classes are passed a WebKit-layer class pointer and they convert that.  This seems to be going the opposite way for reasons I dont' understand.

[Garret Kelly]

(In reply to comment #2)
> (From update of attachment 50043 [details])
> Aren't PlatformTouchEvent used as stack objects?  They're not ref-counted, so I
> assume no one holds pointers to them.  In that case, virtual methods (like
> virtual destructors) make no sense!

Fair enough. I'll remove the virtual destructors.

> This seems like the wrong model.  Normally Platform*Event classes are passed a
> WebKit-layer class pointer and they convert that.  This seems to be going the
> opposite way for reasons I dont' understand.

In Chromium, WebInputEvents (the Chromium layer types) are converted to their WebKit-layer counterparts by subclassing them and handling the conversion in their constructors (The Platform*Builder classes). This logic lives in WebKit/WebKit/chromium/src/WebInputEventConversion.cpp.

[Garret Kelly]

Created attachment 50054 [details]
First-round review changes

Removed virtual destructors from PlatformTouchEvent and PlatformTouchPoint.

[WebKit Commit Bot]

Comment on attachment 50054 [details]
First-round review changes

Clearing flags on attachment: 50054

Committed r55572: <http://trac.webkit.org/changeset/55572>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.