Bug 35759 - When WebGL is enabled, enable hardware compositing bypassing check for CoreVideo bug fix
Summary: When WebGL is enabled, enable hardware compositing bypassing check for CoreVi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-04 11:49 PST by Chris Marrin
Modified: 2010-03-10 21:50 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.31 KB, patch)
2010-03-08 14:34 PST, Chris Marrin
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2010-03-04 11:49:45 PST
HW compositing was turned off for Leopard due to a Core Video bug. This caused crashes sometimes with Video on a HW compositing layer. We could turn it back on if WebGL is turned on. This would limit the exposure of the Core Video bug to those who have opted in to WebGL in a nightly build.

This is related to: https://bugs.webkit.org/show_bug.cgi?id=35338.
Comment 1 Darin Adler 2010-03-07 10:13:18 PST
Seems fine. I would word this as:

    "When WebGL is enabled, enable hardware compositing bypassing check for CoreVideo bug fix"

Or something like that.
Comment 2 Chris Marrin 2010-03-08 14:34:34 PST
Created attachment 50248 [details]
Patch
Comment 3 Chris Marrin 2010-03-08 14:55:45 PST
Landed in http://trac.webkit.org/changeset/55685