Bug 35755 – [Qt] QtLauncher needs an option to toggle FullScreen Mode

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jesus Sanchez-Palencia]

Add an option to QtLauncher so we can toggle between FullScreen and default modes.
On Symbian, the default mode must be a Maximized window.

[Jesus Sanchez-Palencia]

Created attachment 50038 [details]
Add FullScreen option to menu

[Ariya Hidayat]

Comment on attachment 50038 [details]
Add FullScreen option to menu

Overall looks good.

> +signals:
> +    void fullscreen(bool on);

Usually signal name is future (aboutToDoFoo) or past (foobarHasChanged).

> +    // If click pos is the bottom right corner (square with size defined by gExitClickArea)
> +    // and the window is on FullScreen, the window must return to its original state.
> +    if (event->type() == QEvent::MouseButtonRelease) {
> +        QMouseEvent* ev = static_cast<QMouseEvent*>(event);
> +        if (windowState() == Qt::WindowFullScreen
> +            && ev->pos().x() > (size().width() - gExitClickArea)
> +            && ev->pos().y() > (size().height() - gExitClickArea)) {

Using width() and height() directly does not work?

> +    toggleFullScreen->connect(this, SIGNAL(fullscreen(bool)), SLOT(setChecked(bool)));

Is this a correct connection?

[Jesus Sanchez-Palencia]

Created attachment 50052 [details]
Add FullScreen option to menu - v2

Changes after Ariya's review.

[Jesus Sanchez-Palencia]

(In reply to comment #2)
> (From update of attachment 50038 [details])
> Overall looks good.
> 
> > +signals:
> > +    void fullscreen(bool on);
> 
> Usually signal name is future (aboutToDoFoo) or past (foobarHasChanged).

Ok, changed this.

> 
> > +    // If click pos is the bottom right corner (square with size defined by gExitClickArea)
> > +    // and the window is on FullScreen, the window must return to its original state.
> > +    if (event->type() == QEvent::MouseButtonRelease) {
> > +        QMouseEvent* ev = static_cast<QMouseEvent*>(event);
> > +        if (windowState() == Qt::WindowFullScreen
> > +            && ev->pos().x() > (size().width() - gExitClickArea)
> > +            && ev->pos().y() > (size().height() - gExitClickArea)) {
> 
> Using width() and height() directly does not work?

Yes, indeed! Fixed.

> 
> > +    toggleFullScreen->connect(this, SIGNAL(fullscreen(bool)), SLOT(setChecked(bool)));
> 
> Is this a correct connection?

Yes. This is to handle when you exit FullScreen mode by clicking on the "exit area" (bottom right corner), until we have a nice fullscreen button to go there.
I've added a comment to the patch so this won't confuse anyone in the future.

thanks!

[WebKit Commit Bot]

Comment on attachment 50052 [details]
Add FullScreen option to menu - v2

Rejecting patch 50052 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Simon Hausmann', '--force']" exit_code: 1
Last 500 characters of output:
ing file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/QtLauncher/main.cpp
Hunk #3 FAILED at 119.
Hunk #4 succeeded at 188 (offset 1 line).
Hunk #5 succeeded at 200 (offset 1 line).
Hunk #6 succeeded at 311 (offset 1 line).
Hunk #7 succeeded at 389 (offset 1 line).
Hunk #8 succeeded at 539 (offset 1 line).
Hunk #9 FAILED at 553.
Hunk #10 succeeded at 647 (offset 6 lines).
2 out of 10 hunks FAILED -- saving rejects to file WebKitTools/QtLauncher/main.cpp.rej

Full output: http://webkit-commit-queue.appspot.com/results/342785

[Jesus Sanchez-Palencia]

There was a problem with the patches order, I guess. I'll fix this as soon as I'm back from Bossa conference (in 4 days).

[Tor Arne Vestbø]

Please follow the QtWebKit bug reporting guidelines when reporting bugs.

See http://trac.webkit.org/wiki/QtWebKitBugs

Specifically:

  - The 'QtWebKit' component should only be used for bugs/features in the
    public QtWebKit API layer, not to signify that the bug is specific to
    the Qt port of WebKit

      http://trac.webkit.org/wiki/QtWebKitBugs#Component

  - Add the keyword 'Qt' to signal that it's a Qt-related bug

      http://trac.webkit.org/wiki/QtWebKitBugs#Keywords

[Jesus Sanchez-Palencia]

Created attachment 50534 [details]
Add FullScreen option to menu - v3

Fixed.

[WebKit Commit Bot]

Comment on attachment 50534 [details]
Add FullScreen option to menu - v3

Clearing flags on attachment: 50534

Committed r55951: <http://trac.webkit.org/changeset/55951>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.