Bug 35727 – [GTK] GTK_WIDGET_NO_WINDOW deprecated in GTK+ 2.20

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Philippe Normand]

We should use gtk_widget_set_has_window() instead if GTK version is >= 2.18.

[Philippe Normand]

I meant gtk_widget_get_has_window of course :)

[Philippe Normand]

Created attachment 49999 [details]
proposed patch

[Eric Seidel (no email)]

Comment on attachment 49999 [details]
proposed patch

Can we wrap this in some helper function?  Copy/paste 4 times seems silly.  Even if we just used a helper function in GtkWidget.cpp that would be better than this.

[Philippe Normand]

Created attachment 50195 [details]
proposed patch

[Gustavo Noronha (kov)]

Comment on attachment 50195 [details]
proposed patch

 24 #if GTK_CHECK_VERSION(2, 18, 0)
 25 #define WIDGET_HAS_WINDOW(widget) gtk_widget_get_has_window(widget)
 26 #else
 27 #define WIDGET_HAS_WINDOW(widget) !GTK_WIDGET_NO_WINDOW(widget)

I think creating a utils file just for this is not worth it. Why not add a function to the WidgetGtk class (or file), as Eric suggested?

 691 #if GTK_CHECK_VERSION(2, 18, 0)
 692     if (gtk_widget_is_sensitive(widget)) {
 693 #else
691694     if (GTK_WIDGET_IS_SENSITIVE(widget)) {
 695 #endif

This is unrelated. Please put it into another patch.

[Philippe Normand]

(In reply to comment #5)
> (From update of attachment 50195 [details])
>  24 #if GTK_CHECK_VERSION(2, 18, 0)
>  25 #define WIDGET_HAS_WINDOW(widget) gtk_widget_get_has_window(widget)
>  26 #else
>  27 #define WIDGET_HAS_WINDOW(widget) !GTK_WIDGET_NO_WINDOW(widget)
> 
> I think creating a utils file just for this is not worth it. Why not add a
> function to the WidgetGtk class (or file), as Eric suggested?
> 

Ok can you tell me what you want exactly? a method of the class or a static function?

>  691 #if GTK_CHECK_VERSION(2, 18, 0)
>  692     if (gtk_widget_is_sensitive(widget)) {
>  693 #else
> 691694     if (GTK_WIDGET_IS_SENSITIVE(widget)) {
>  695 #endif
> 
> This is unrelated. Please put it into another patch.

I just put it in this patch because it was fixing my build for the same reasons (gtk deprecating apis)... but yeah fine, it just adds one patch in the queue :P