Bug 35713 - undo after smartdelete should select the deleted space
Summary: undo after smartdelete should select the deleted space
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-03 18:36 PST by Ojan Vafai
Modified: 2010-03-09 15:41 PST (History)
5 users (show)

See Also:


Attachments
Patch (9.87 KB, patch)
2010-03-03 18:40 PST, Ojan Vafai
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2010-03-03 18:36:43 PST
undo after smartdelete should select the deleted space
Comment 1 Ojan Vafai 2010-03-03 18:40:13 PST
Created attachment 49976 [details]
Patch
Comment 2 Adam Barth 2010-03-09 11:06:01 PST
Comment on attachment 49976 [details]
Patch

Ojan is slowly teaching me the editing code.  I'd prefer to have someone more expert review these patches, but no one seems to be forthcoming.

+ void setStartingSelectionOnSmartDelete(Position&, Position&);

Why pass these by reference instead of by constant reference?
Comment 3 Ojan Vafai 2010-03-09 15:41:46 PST
Committed r55752: <http://trac.webkit.org/changeset/55752>