Bug 35710 - [chromium] DateExtension fires incorrectly
Summary: [chromium] DateExtension fires incorrectly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: John Abd-El-Malek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-03 17:04 PST by John Abd-El-Malek
Modified: 2010-03-04 01:24 PST (History)
4 users (show)

See Also:

Attachments
Proposed patch (2.95 KB, patch)
2010-03-03 17:11 PST, John Abd-El-Malek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Abd-El-Malek 2010-03-03 17:04:44 PST 
Full background here: http://code.google.com/p/chromium/issues/detail?id=33441#makechanges

The problem was this line:
argv[0] = v8::String::New(allow ? "false" : "true");

since the JS function did "if (enable)" and treated the string as bool, it was always true.
Comment 1 John Abd-El-Malek 2010-03-03 17:11:47 PST 
Created attachment 49965 [details]
Proposed patch
Comment 2 Adam Barth 2010-03-03 17:23:39 PST 
Comment on attachment 49965 [details]
Proposed patch

Type FTW
Comment 3 John Abd-El-Malek 2010-03-03 17:31:52 PST 
Thanks for the quick review!
Comment 4 WebKit Commit Bot 2010-03-04 01:24:52 PST 
Comment on attachment 49965 [details]
Proposed patch

Clearing flags on attachment: 49965

Committed r55513: <http://trac.webkit.org/changeset/55513>
Comment 5 WebKit Commit Bot 2010-03-04 01:24:56 PST 
All reviewed patches have been landed.  Closing bug.