Bug 35710 - [chromium] DateExtension fires incorrectly
: [chromium] DateExtension fires incorrectly
Status: RESOLVED FIXED
: WebKit
Platform
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-03-03 17:04 PST by
Modified: 2010-03-04 01:24 PST (History)


Attachments
Proposed patch (2.95 KB, patch)
2010-03-03 17:11 PST, John Abd-El-Malek
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-03-03 17:04:44 PST
Full background here: http://code.google.com/p/chromium/issues/detail?id=33441#makechanges

The problem was this line:
argv[0] = v8::String::New(allow ? "false" : "true");

since the JS function did "if (enable)" and treated the string as bool, it was always true.
------- Comment #1 From 2010-03-03 17:11:47 PST -------
Created an attachment (id=49965) [details]
Proposed patch
------- Comment #2 From 2010-03-03 17:23:39 PST -------
(From update of attachment 49965 [details])
Type FTW
------- Comment #3 From 2010-03-03 17:31:52 PST -------
Thanks for the quick review!
------- Comment #4 From 2010-03-04 01:24:52 PST -------
(From update of attachment 49965 [details])
Clearing flags on attachment: 49965

Committed r55513: <http://trac.webkit.org/changeset/55513>
------- Comment #5 From 2010-03-04 01:24:56 PST -------
All reviewed patches have been landed.  Closing bug.