Bug 35697 - [V8] Clean up CodeGeneratorV8.pm
Summary: [V8] Clean up CodeGeneratorV8.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-03 13:02 PST by Nate Chapin
Modified: 2010-03-05 10:07 PST (History)
0 users

See Also:


Attachments
patch (56.88 KB, patch)
2010-03-03 13:07 PST, Nate Chapin
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2010-03-03 13:02:01 PST
To start with:
1. Remove some of the unused subroutines
2. Make GetInternalFields less hard-coded (though it will still need some special cases).
3. Make the generated code (mostly) match the WebKit style guide.
Comment 1 Nate Chapin 2010-03-03 13:07:14 PST
Created attachment 49936 [details]
patch
Comment 2 Dimitri Glazkov (Google) 2010-03-04 16:09:58 PST
Comment on attachment 49936 [details]
patch

why do you keep removing code? what has it done to you?
Comment 3 Nate Chapin 2010-03-05 10:07:19 PST
http://trac.webkit.org/changeset/55586