Bug 35687 - [Qt] fast/canvas/quadraticCurveTo.xml failed and skipped
Summary: [Qt] fast/canvas/quadraticCurveTo.xml failed and skipped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-03 07:51 PST by Chang Shu
Modified: 2010-03-04 10:51 PST (History)
2 users (show)

See Also:

Attachments
fix patch (17.21 KB, patch)
2010-03-03 07:55 PST, Chang Shu 		kenneth: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
rebase patch (17.70 KB, patch)
2010-03-04 08:09 PST, Chang Shu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2010-03-03 07:51:55 PST 
The above test case failed and was put into skipped list.
Comment 1 Chang Shu 2010-03-03 07:55:25 PST 
Created attachment 49911 [details]
fix patch
Comment 2 WebKit Commit Bot 2010-03-04 07:50:17 PST 
Comment on attachment 49911 [details]
fix patch

Rejecting patch 49911 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Kenneth Rohde Christiansen', '--force']" exit_code: 1
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/qt/Skipped
Hunk #1 FAILED at 95.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/Skipped.rej
patching file LayoutTests/platform/qt/fast/canvas/quadraticCurveTo-expected.checksum
patching file LayoutTests/platform/qt/fast/canvas/quadraticCurveTo-expected.txt

Full output: http://webkit-commit-queue.appspot.com/results/332586
Comment 3 Chang Shu 2010-03-04 08:09:28 PST 
Created attachment 50025 [details]
rebase patch

I re-based the patch with latest code.
Comment 4 Chang Shu 2010-03-04 10:02:59 PST 
Kenneth, can you set the r+ again? thanks!
Comment 5 Chang Shu 2010-03-04 10:34:35 PST 
Comment on attachment 50025 [details]
rebase patch

will commit manually
Comment 6 Alexey Proskuryakov 2010-03-04 10:48:03 PST 
http://trac.webkit.org/changeset/55533

In the future, please paste ChangeLog entry as commit message, to make svn logs more informative.
Comment 7 Alexey Proskuryakov 2010-03-04 10:49:08 PST 
Should this be marked as fixed?
Comment 8 Chang Shu 2010-03-04 10:51:44 PST 
(In reply to comment #6)
> http://trac.webkit.org/changeset/55533
> 
> In the future, please paste ChangeLog entry as commit message, to make svn logs
> more informative.

Sorry, Ossy just told me to use commit-log-editor in the future. Will keep in mind. :)