Bug 35666 - [Gtk]: assertion triggered when geolocation getCurrentPosition without an option argument.
Summary: [Gtk]: assertion triggered when geolocation getCurrentPosition without an opt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-03 03:50 PST by arno.
Modified: 2010-03-03 05:30 PST (History)
1 user (show)

See Also:

Attachments
patch v1 (1.28 KB, patch)
2010-03-03 03:54 PST, arno. 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description arno. 2010-03-03 03:50:51 PST 
Hi,

when getCurrentPosition is called without an option argument (or with an object that don't have a timeout property), PositionOptions does not have a timeout (m_hasTimeout is false).

Currently in GeolocationServiceGtk::startUpdating, we have following code:
timeout = options->timeout();
without checking if options->hasTimeout().

We should check if options has a timeout before trying to get its value.
Comment 1 arno. 2010-03-03 03:54:01 PST 
Created attachment 49897 [details]
patch v1
Comment 2 Gustavo Noronha (kov) 2010-03-03 05:14:00 PST 
Comment on attachment 49897 [details]
patch v1

Looks sane, from looking at the PositionOptions code.
Comment 3 WebKit Commit Bot 2010-03-03 05:30:55 PST 
Comment on attachment 49897 [details]
patch v1

Clearing flags on attachment: 49897

Committed r55459: <http://trac.webkit.org/changeset/55459>
Comment 4 WebKit Commit Bot 2010-03-03 05:30:59 PST 
All reviewed patches have been landed.  Closing bug.