Bug 35629 - [Chromium] Should remove paddings of Win/Linux chromium's buttons
Summary: [Chromium] Should remove paddings of Win/Linux chromium's buttons
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
: 31703 (view as bug list)
Depends on:
Reported: 2010-03-02 22:18 PST by Shinichiro Hamaji
Modified: 2010-03-26 17:36 PDT (History)
3 users (show)

See Also:

Patch v1 (2.24 KB, patch)
2010-03-02 22:20 PST, Shinichiro Hamaji
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2010-03-02 22:18:09 PST
Per discussion on Bug 35231 and http://code.google.com/p/chromium/issues/detail?id=1437 , let's remove the extra paddings which causes web compatibility issues.
Comment 1 Shinichiro Hamaji 2010-03-02 22:20:21 PST
Created attachment 49878 [details]
Patch v1
Comment 2 Shinichiro Hamaji 2010-03-02 22:22:30 PST
> Created an attachment (id=49878) [details]
> Patch v1

Or, should we remove buttonInternalPadding* even from RenderTheme ? David, could you give me your suggestion if you have any opinion about this?
Comment 3 Shinichiro Hamaji 2010-03-02 22:25:28 PST
Comment on attachment 49878 [details]
Patch v1

cq- because this patch will break bunch of chromium's layout tests so I need to communicate with WebKit sheriff before I land this patch.
Comment 4 Eric Seidel (no email) 2010-03-05 16:25:23 PST
Comment on attachment 49878 [details]
Patch v1

Comment 5 Ojan Vafai 2010-03-05 16:55:35 PST
To give context for this. We've found a number of sites whose layout breaks due to this extra internal padding. We originally added this to match Firefox since padding:0 buttons look pretty crappy without having any internal padding.

Chromium would like to run an experiment removing the padding and see if there's any fallout. We're hoping that not many sites use padding:0. If it turns out they do, then we'll probably revert this change. If they don't, we should consider making Safari Win also not having internal button padding.

Some sites that break with the internal padding:
Comment 6 Shinichiro Hamaji 2010-03-09 00:24:12 PST
Comment on attachment 49878 [details]
Patch v1

Clearing flags on attachment: 49878

Committed r55714: <http://trac.webkit.org/changeset/55714>
Comment 7 Shinichiro Hamaji 2010-03-09 00:24:21 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Erik Arvidsson 2010-03-26 17:36:03 PDT
*** Bug 31703 has been marked as a duplicate of this bug. ***