Bug 35627 - Rework r55443 to avoid #ifdefs in Page.cpp
Summary: Rework r55443 to avoid #ifdefs in Page.cpp
Status: RESOLVED DUPLICATE of bug 35623
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-02 20:16 PST by Darin Fisher (:fishd, Google)
Modified: 2010-03-02 20:17 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2010-03-02 20:16:44 PST 
Rework http://trac.webkit.org/changeset/55443 to avoid #ifdefs in Page.cpp

One idea is to move the body of Page::privateBrowsingStateChanged to a
static function on PluginView.  That function would be passed the Page,
and it would then iterate over the list of PluginViews and notify each.

This way PluginViewNone.cpp can just have an empty body for that static
method.
Comment 1 Mark Rowe (bdash) 2010-03-02 20:17:45 PST 

*** This bug has been marked as a duplicate of bug 35623 ***