WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 35623
35627
Rework
r55443
to avoid #ifdefs in Page.cpp
https://bugs.webkit.org/show_bug.cgi?id=35627
Summary
Rework r55443 to avoid #ifdefs in Page.cpp
Darin Fisher (:fishd, Google)
Reported
2010-03-02 20:16:44 PST
Rework
http://trac.webkit.org/changeset/55443
to avoid #ifdefs in Page.cpp One idea is to move the body of Page::privateBrowsingStateChanged to a static function on PluginView. That function would be passed the Page, and it would then iterate over the list of PluginViews and notify each. This way PluginViewNone.cpp can just have an empty body for that static method.
Attachments
Add attachment
proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1
2010-03-02 20:17:45 PST
*** This bug has been marked as a duplicate of
bug 35623
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug