Bug 35614 - delete pywebsocket dir again (revert r55339)
Summary: delete pywebsocket dir again (revert r55339)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-02 15:46 PST by Dirk Pranke
Modified: 2010-03-03 10:35 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.06 KB, patch)
2010-03-02 15:49 PST, Dirk Pranke 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-03-02 15:46:40 PST 
delete pywebsocket dir again (revert r55339)
Comment 1 Dirk Pranke 2010-03-02 15:49:13 PST 
Created attachment 49858 [details]
Patch
Comment 2 Dirk Pranke 2010-03-02 16:17:06 PST 
Committed r55439: <http://trac.webkit.org/changeset/55439>
Comment 3 Chris Jerdonek 2010-03-03 10:35:29 PST 
+        Revert r55339 - the Chromium codebase downstream had a temporary
+        need for WebKitTools/pywebsocket to still exist after Chris Jerdonek
+        had moved it (scripts still referenced the old location). Those
+        scripts have been updated to the new location, so it should be safe
+        to delete this now.

If possible, it's probably better to arrange things on the Chromium side to only depends on things located in WebKitTools/Scripts (rather than on the location of things in the internal API).  This may require adding a new script to the Scripts folder.  That way if we ever move something in webkitpy again, people in WebKit will be able to update the dependent scripts in WebKitTools/Scripts accordingly.