Bug 35613 - Document cookieURL and firstPartyForCookies
Summary: Document cookieURL and firstPartyForCookies
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-03-02 15:10 PST by Adam Barth
Modified: 2010-03-03 06:48 PST (History)
3 users (show)

See Also:

Patch (2.15 KB, patch)
2010-03-02 15:11 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (2.14 KB, patch)
2010-03-02 15:19 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (2.14 KB, patch)
2010-03-02 17:07 PST, Adam Barth
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-03-02 15:10:46 PST
Document cookieURL and firstPartyForCookies
Comment 1 Adam Barth 2010-03-02 15:11:59 PST
Created attachment 49855 [details]
Comment 2 Adam Barth 2010-03-02 15:19:38 PST
Created attachment 49856 [details]
Comment 3 Darin Adler 2010-03-02 17:00:07 PST
Comment on attachment 49856 [details]

> +    //    inherits its cookieURL but not it's URL.

its URL
Comment 4 Alexey Proskuryakov 2010-03-02 17:04:31 PST
+    // A: The two URLs are the same almost all the time.  However, if one
+    //    document inherits the security context of another document, it
+    //    inherits its cookieURL but not it's URL.

It's interesting that we have this code:

void Document::open(Document* ownerDocument)
    if (ownerDocument) {
        m_cookieURL = ownerDocument->cookieURL();
Comment 5 Adam Barth 2010-03-02 17:07:35 PST
Created attachment 49869 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2010-03-03 00:31:44 PST
Comment on attachment 49869 [details]
Patch for landing

Rejecting patch 49869 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/dom/Document.h
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following ChangeLog files contain OOPS:


    Please don't ever say "OOPS" in a ChangeLog file.
 at /usr/local/git/libexec/git-core/git-svn line 558

Full output: http://webkit-commit-queue.appspot.com/results/323345
Comment 7 Adam Barth 2010-03-03 06:48:44 PST
Committed r55461: <http://trac.webkit.org/changeset/55461>