Bug 35613 – Document cookieURL and firstPartyForCookies

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Document cookieURL and firstPartyForCookies

[Adam Barth]

Created attachment 49855 [details]
Patch

[Adam Barth]

Created attachment 49856 [details]
Patch

[Darin Adler]

Comment on attachment 49856 [details]
Patch

> +    //    inherits its cookieURL but not it's URL.

its URL

[Alexey Proskuryakov]

+    // A: The two URLs are the same almost all the time.  However, if one
+    //    document inherits the security context of another document, it
+    //    inherits its cookieURL but not it's URL.

It's interesting that we have this code:

void Document::open(Document* ownerDocument)
{
    if (ownerDocument) {
        setURL(ownerDocument->url());
        m_cookieURL = ownerDocument->cookieURL();

[Adam Barth]

Created attachment 49869 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 49869 [details]
Patch for landing

Rejecting patch 49869 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/dom/Document.h
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following ChangeLog files contain OOPS:

        trunk/WebCore/ChangeLog

    Please don't ever say "OOPS" in a ChangeLog file.
 at /usr/local/git/libexec/git-core/git-svn line 558


Full output: http://webkit-commit-queue.appspot.com/results/323345

[Adam Barth]

Committed r55461: <http://trac.webkit.org/changeset/55461>