Bug 35600 - shouldBe() fails when comparing an array to null
Summary: shouldBe() fails when comparing an array to null
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-02 13:48 PST by Alexey Proskuryakov
Modified: 2010-03-02 14:26 PST (History)
1 user (show)

See Also:


Attachments
proposed fix (1.41 KB, patch)
2010-03-02 13:50 PST, Alexey Proskuryakov
aroben: review+
Details | Formatted Diff | Diff
a working fix (1.44 KB, patch)
2010-03-02 14:10 PST, Alexey Proskuryakov
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-03-02 13:48:15 PST
Patch forthcoming.
Comment 1 Alexey Proskuryakov 2010-03-02 13:50:06 PST
Created attachment 49842 [details]
proposed fix
Comment 2 Adam Roben (:aroben) 2010-03-02 13:52:32 PST
Comment on attachment 49842 [details]
proposed fix

r=me
Comment 3 Alexey Proskuryakov 2010-03-02 14:10:46 PST
Created attachment 49847 [details]
a working fix
Comment 4 Adam Roben (:aroben) 2010-03-02 14:12:46 PST
Comment on attachment 49847 [details]
a working fix

Is there any value in communicating more information about what happened?

r=me
Comment 5 Alexey Proskuryakov 2010-03-02 14:26:18 PST
Committed <http://trac.webkit.org/changeset/55430>.

> Is there any value in communicating more information about what happened?

Not in this specific case - shouldBe(myArray, null) just needs to silently return false. It may be more interesting in other cases, but it may be not.