Bug 35592 – Expose a WebDocument::firstPartyForCookies property

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Wan-Teh Chang]

This bug proposes that we add a firstPartyForCookies method
to WebDocument to expose the firstPartyForCookies property of
the underlying Document.  This was suggested by Darin Fisher
in Chromium code review http://codereview.chromium.org/601038.

The attached patch does that.  I'm having problem running the
prepare-ChangeLog script, so the patch was not generated properly.
Here is the prepare-ChangeLog error I got:

$ /d/chrome-nss-static/src/third_party/WebKit/WebKitTools/Scripts/prepare-Chang
eLog  --name="Wan-Teh Chang" --email=[e-mail] WebKit/chromium
  Running status to find changed, added, or removed files.
?       WebKit\chromium\WebKit.sln
?       WebKit\chromium\webkit.vcproj
?       WebKit\chromium\webkit_unit_tests.vcproj.GOOGLE.wtc.user
?       WebKit\chromium\webkit_unit_tests.vcproj
?       WebKit\chromium\webkit.vcproj.GOOGLE.wtc.user
  Reviewing diff to determine which lines changed.
  Extracting affected function names from source files.
  Change author: Wan-Teh Chang <[e-mail]>.
  Running 'svn update' to update ChangeLog files.
Can't use an undefined value as filehandle reference at /d/chrome-nss-static/src
/third_party/WebKit/WebKitTools/Scripts/prepare-ChangeLog line 328.

[Wan-Teh Chang]

Created attachment 49820 [details]
Patch (not generated properly)

[Darin Fisher (:fishd, Google)]

Try running prepare-ChangeLog from within the WebKit/chromium directory.

[Wan-Teh Chang]

Created attachment 49953 [details]
Proposed patch

Eric Roman generated a patch properly.

[Darin Fisher (:fishd, Google)]

Comment on attachment 49953 [details]
Proposed patch

> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 55480)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,13 @@
> [phone]  Eric Roman  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Add a firstPartyForCookies() property to WebDocument.

actually, this needs to include a link back to this bug.  sorry for
wasting cycles.  please add this link before committing.

r=me otherwise (cq- because this patch needs an edit before it can
be committed)

[Wan-Teh Chang]

Created attachment 49954 [details]
Proposed patch (with link to bug report)

No problem.  Here it is.

[WebKit Commit Bot]

Comment on attachment 49954 [details]
Proposed patch (with link to bug report)

Rejecting patch 49954 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Fisher', '--force']" exit_code: 1
Last 500 characters of output:
-------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: src/WebDocument.cpp
|===================================================================
|--- src/WebDocument.cpp	(revision 55462)
|+++ src/WebDocument.cpp	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored

Full output: http://webkit-commit-queue.appspot.com/results/332304

[Adam Barth]

Comment on attachment 49954 [details]
Proposed patch (with link to bug report)

This patch is incorrectly based in $WEBKIT/WebKit/chromium instead of in $WEBKIT itself.  It will need to be landed manually.

[WebKit Commit Bot]

Comment on attachment 49953 [details]
Proposed patch

Cleared Darin Fisher's review+ from obsolete attachment 49953 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Wan-Teh Chang]

Created attachment 50609 [details]
Proposed patch (with correct pathnames)

I fixed the pathnames in the patch.  Please review again.
Sorry to waste your time.

[Adam Barth]

Comment on attachment 50609 [details]
Proposed patch (with correct pathnames)

No worries.

[WebKit Commit Bot]

Comment on attachment 50609 [details]
Proposed patch (with correct pathnames)

Clearing flags on attachment: 50609

Committed r55952: <http://trac.webkit.org/changeset/55952>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.