Bug 35588 - [V8] NPN_GetProperty shouldn't crash if the property doesn't exist
Summary: [V8] NPN_GetProperty shouldn't crash if the property doesn't exist
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-02 10:40 PST by Nate Chapin
Modified: 2010-03-02 17:11 PST (History)
2 users (show)

See Also:


Attachments
patch (1.30 KB, patch)
2010-03-02 10:43 PST, Nate Chapin
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2010-03-02 10:40:02 PST
Currently, if the property doesn't exist, v8::Object::Get() returns an empty handle and we fail an ASSERT when we try to convert that handle to an NPVariant, so we should exit early before trying to convert.
Comment 1 Nate Chapin 2010-03-02 10:43:01 PST
Created attachment 49818 [details]
patch
Comment 2 Dimitri Glazkov (Google) 2010-03-02 11:07:07 PST
Comment on attachment 49818 [details]
patch

ok.
Comment 3 Alexey Proskuryakov 2010-03-02 17:11:50 PST
This was landed in <http://trac.webkit.org/changeset/55417>.