What the title says.
Created attachment 49812 [details] patch
Attachment 49812 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/IntPoint.h:220: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 49812 [details] patch In the case of WebCore::String we chose to put the hashing into a separate header rather than adding HashFunctions.h and HashTraits.h into every files that includes PlatformString.h. Perhaps we should do the same thing here?
(In reply to comment #3) > (From update of attachment 49812 [details]) > In the case of WebCore::String we chose to put the hashing into a separate > header rather than adding HashFunctions.h and HashTraits.h into every files > that includes PlatformString.h. Perhaps we should do the same thing here? Yeah, good idea. This is included all over.
Created attachment 49896 [details] move to IntPointHash.h to avoid including hash headers all over the place
Comment on attachment 49896 [details] move to IntPointHash.h to avoid including hash headers all over the place r=me, assuming you remove the superfluous project file changes
Sending WebCore/ChangeLog Sending WebCore/WebCore.pro Sending WebCore/WebCore.xcodeproj/project.pbxproj Adding WebCore/platform/graphics/IntPointHash.h Transmitting file data .... Committed revision 55455.