Bug 35575 - [V8] crash when a plugin throws a javascript exception when no v8 context exists
Summary: [V8] crash when a plugin throws a javascript exception when no v8 context exists
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-02 03:42 PST by Leon Clarke
Modified: 2013-05-02 11:24 PDT (History)
4 users (show)

See Also:

Attachments
Patch 1 (1.45 KB, patch)
2010-03-02 03:53 PST, Leon Clarke 		ap: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leon Clarke 2010-03-02 03:42:24 PST 
When a plugin sets a script exception on an object that isn't a javascript object, we would usually attempt to log it to the javascript console. However, if there isn't a javascript context (e.g. the page doesn't contain any javascript) then v8 isn't initialized enough to pass the error on. In this situation, we should throw the error away rather than crashing.
Comment 1 Leon Clarke 2010-03-02 03:53:43 PST 
Created attachment 49799 [details]
Patch 1
Comment 2 Nate Chapin 2010-03-02 10:46:48 PST 
Comment on attachment 49799 [details]
Patch 1

LGTM. Thanks!


Do you need commit-queue+ as well?
Comment 3 Leon Clarke 2010-03-02 10:49:49 PST 
Yes please. That'd be great.
Comment 4 Alexey Proskuryakov 2010-03-02 15:39:52 PST 
Comment on attachment 49799 [details]
Patch 1

Is this covered by existing regression tests? Please add add a test if it's not.

r-, since there is no test, and no explanation why one isn't necessary.
Comment 5 Anders Carlsson 2013-05-02 11:24:53 PDT 
V8 is gone from WebKit.