RESOLVED FIXED 35560
new-run-webkit-tests crashes when DRT returns zero-bytes in a read 
https://bugs.webkit.org/show_bug.cgi?id=35560
Summary new-run-webkit-tests crashes when DRT returns zero-bytes in a read
Dirk Pranke
Reported 2010-03-01 18:58:23 PST
new-run-webkit-tests crashes when DRT returns zero-bytes in a read
Attachments
Patch (8.29 KB, patch)
2010-03-01 19:01 PST, Dirk Pranke 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-03-01 19:01:06 PST
Created attachment 49774 [details] Patch
Ojan Vafai
Comment 2 2010-03-05 17:18:14 PST
Comment on attachment 49774 [details] Patch Can you wrap just the bits that need to be in a try/except? Wrapping everything makes for lots of unnecessary indents and makes the code less explicit about what the try/except is needed for.
Dirk Pranke
Comment 3 2010-03-05 17:23:17 PST
Yeah, I can look into that.
Eric Seidel (no email)
Comment 4 2010-03-15 16:00:17 PDT
Comment on attachment 49774 [details] Patch Given the above comments, marking r- for now.
Eric Seidel (no email)
Comment 5 2010-04-11 00:18:13 PDT
Is this still an issue?
Dirk Pranke
Comment 6 2010-04-11 11:17:11 PDT
I don't think this is still an issue (after having rewritten the code to use the ServerProcess class), but I need to write some tests to be sure. The Chromium ports need to be rewritten to use the ServerProcess class as well, so I want to leave this open until I make that change and add some unit tests that test crash handling.
Dirk Pranke
Comment 7 2010-04-11 18:44:14 PDT
actually, after doing some unit testing by hand, I can confirm that this bug is fixed, and it's probably less confusing to open separate bugs for the other two tasks.
Note You need to log in before you can comment on or make changes to this bug.