Bug 35554 - Some WebKit DOMNode API is unimplemented
Summary: Some WebKit DOMNode API is unimplemented
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Jon Honeycutt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-01 16:39 PST by Jon Honeycutt
Modified: 2010-03-01 20:15 PST (History)
0 users

See Also:


Attachments
patch (4.94 KB, patch)
2010-03-01 18:15 PST, Jon Honeycutt
jhoneycutt: commit-queue-
Details | Formatted Diff | Diff
patch v2 (4.94 KB, patch)
2010-03-01 18:44 PST, Jon Honeycutt
alice.barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Honeycutt 2010-03-01 16:39:26 PST
DOMNode::nextSibling(), DOMNode::insertBefore(), and DOMNode::removeChild() are unimplemented.
Comment 1 Jon Honeycutt 2010-03-01 18:15:49 PST
Created attachment 49767 [details]
patch
Comment 2 Jon Honeycutt 2010-03-01 18:44:33 PST
Created attachment 49771 [details]
patch v2

Fix the check in DOMNode::removeChild() to check if oldChildNode is null, rather than oldChild.
Comment 3 Jon Honeycutt 2010-03-01 20:15:35 PST
Committed in r55398.