RESOLVED FIXED 35553
new-run-webkit-tests doesn't clean up drivers properly 
https://bugs.webkit.org/show_bug.cgi?id=35553
Summary new-run-webkit-tests doesn't clean up drivers properly
Dirk Pranke
Reported 2010-03-01 16:34:02 PST
It turns out that there's a bug in Python ( http://bugs.python.org/issue2320 ) where subprocess.Popen() may get corrupted if you call it from multiple threads. The result is that trying to close the child file descriptors may not work properly, and as a result we end up not cleaning up test_shell / DumpRenderTree properly when we stop it. Workaround is to call subprocess.Popen() with close_fds=True .
Attachments
patch to spawn and stop dumprendertree/test_shell properly (5.98 KB, patch)
2010-03-01 16:41 PST, Dirk Pranke 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-03-01 16:41:08 PST
Created attachment 49764 [details] patch to spawn and stop dumprendertree/test_shell properly
Eric Seidel (no email)
Comment 2 2010-03-01 16:53:24 PST
Comment on attachment 49764 [details] patch to spawn and stop dumprendertree/test_shell properly We really need to wrap this stuff in some helper functions. But this is better than what we had.
Dirk Pranke
Comment 3 2010-03-01 16:54:50 PST
Yeah, I think I can refactor the common driver code up into base.py ; I will look at doing that in a separate change.
Adam Barth
Comment 4 2010-03-01 16:55:24 PST
I feel like this code is copy/pasted twice. Can't we factor it into a common base class? (Not a requirement before landing this patch.)
Dirk Pranke
Comment 5 2010-03-01 17:07:21 PST
Committed r55388: <http://trac.webkit.org/changeset/55388>
Dirk Pranke
Comment 6 2010-03-01 17:29:52 PST
Committed r55391: <http://trac.webkit.org/changeset/55391>
Note You need to log in before you can comment on or make changes to this bug.