Bug 35552 - [V8] DOMCoreException should be visible as DOMException
Summary: [V8] DOMCoreException should be visible as DOMException
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
Depends on:
Reported: 2010-03-01 16:01 PST by Jian Li
Modified: 2010-03-02 11:05 PST (History)
1 user (show)

See Also:

Proposed Patch (2.02 KB, patch)
2010-03-01 16:35 PST, Jian Li
japhet: review+
jianli: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2010-03-01 16:01:06 PST
We need to make DOMCoreException be visible as DOMException, similar to what JSC code generator does. This will fix several wrong layout test results, like LayoutTests/fast/dom/DOMException/prototype-object.html has the following wrong result:

FAIL Object.prototype.toString.call(e) should be [object DOMException]. Was [object DOMCoreException].
FAIL e.constructor.toString() should be [object DOMExceptionConstructor]. Was function DOMCoreException() { [native code] }.

This will also apply to FormData interface I am going to add at 26979.
Comment 1 Jian Li 2010-03-01 16:35:17 PST
Created attachment 49763 [details]
Proposed Patch
Comment 2 Nate Chapin 2010-03-02 10:48:23 PST
Comment on attachment 49763 [details]
Proposed Patch

Yay for passing layout tests!
Comment 3 Jian Li 2010-03-02 11:05:11 PST
Committed as http://trac.webkit.org/changeset/55416.