Bug 35541 - webkit-patch land fails for security bugs
Summary: webkit-patch land fails for security bugs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-01 13:30 PST by Kenneth Russell
Modified: 2010-03-22 23:11 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-03-01 13:30:30 PST
Trying to use webkit-patch land to commit a security fix, I received the following traceback:

Fetching: https://bugs.webkit.org/show_bug.cgi?id=35241&ctype=xml
Traceback (most recent call last):
  File "/Users/kbr/src/chrome/src/third_party/WebKit/WebKitTools/Scripts/webkit-patch", line 109, in <module>
    WebKitPatch().main()
  File "/Users/kbr/src/chrome/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 299, in main
    return command.check_arguments_and_execute(options, args, self)
  File "/Users/kbr/src/chrome/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 113, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Users/kbr/src/chrome/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/commands/abstractsequencedcommand.py", line 43, in execute
    self._sequence.run_and_handle_errors(tool, options, self._prepare_state(options, args, tool))
  File "/Users/kbr/src/chrome/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/stepsequence.py", line 66, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Users/kbr/src/chrome/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/stepsequence.py", line 60, in _run
    step(tool, options).run(state)
  File "/Users/kbr/src/chrome/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/steps/updatechangelogswithreviewer.py", line 63, in run
    reviewer = self._guess_reviewer_from_bug(bug_id)
  File "/Users/kbr/src/chrome/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/steps/updatechangelogswithreviewer.py", line 45, in _guess_reviewer_from_bug
    patches = self._tool.bugs.fetch_bug(bug_id).reviewed_patches()
  File "/Users/kbr/src/chrome/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/bugzilla.py", line 426, in fetch_bug
    return Bug(self.fetch_bug_dictionary(bug_id), self)
  File "/Users/kbr/src/chrome/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/bugzilla.py", line 421, in fetch_bug_dictionary
    return self._parse_bug_page(self._fetch_bug_page(bug_id))
  File "/Users/kbr/src/chrome/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/bugzilla.py", line 404, in _parse_bug_page
    bug["title"] = unicode(soup.find("short_desc").string)
AttributeError: 'NoneType' object has no attribute 'string'

I'm not sure whether I set up something incorrectly in my environment so that webkit-patch doesn't know how to authenticate.
Comment 1 Adam Barth 2010-03-01 13:34:09 PST
Yeah, we don't handle this case very well.  It's a matter of (1) making sure webkit-patch has your credentials and (2) making sure it authenticates every request using those credentials.
Comment 2 Fumitoshi Ukai 2010-03-22 23:11:28 PDT
I believe this was fixed at r55704