Bug 35535 - Web Inspector: render breakpoints as border images instead of canvas.
Summary: Web Inspector: render breakpoints as border images instead of canvas.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-01 12:31 PST by Pavel Feldman
Modified: 2010-03-02 06:37 PST (History)
4 users (show)

See Also:

Attachments
[IMAGE] Screenshot while running with patch. (15.47 KB, image/png)
2010-03-01 12:33 PST, Pavel Feldman 		no flags Details
[PATCH] Proposed change. (15.35 KB, patch)
2010-03-01 12:35 PST, Pavel Feldman 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-03-01 12:31:47 PST 
Now that the line number gutter is of variable width, we should support variable width breakpoint images.
Comment 1 Pavel Feldman 2010-03-01 12:33:28 PST 
Created attachment 49735 [details]
[IMAGE] Screenshot while running with patch.
Comment 2 Pavel Feldman 2010-03-01 12:35:37 PST 
Created attachment 49736 [details]
[PATCH] Proposed change.
Comment 3 Timothy Hatcher 2010-03-01 13:22:31 PST 
Comment on attachment 49736 [details]
[PATCH] Proposed change.

You can use -webkit-canvas() as a border-image. But I am fine checking in static images too.
Comment 4 Pavel Feldman 2010-03-02 06:37:50 PST 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	A	WebCore/inspector/front-end/Images/breakpointBorder.png
	A	WebCore/inspector/front-end/Images/breakpointConditionalBorder.png
	A	WebCore/inspector/front-end/Images/breakpointConditionalCounterBorder.png
	A	WebCore/inspector/front-end/Images/breakpointCounterBorder.png
	A	WebCore/inspector/front-end/Images/programCounterBorder.png
	M	WebCore/inspector/front-end/SourceFrame.js
	M	WebCore/inspector/front-end/TextViewer.js
	M	WebCore/inspector/front-end/textViewer.css
Committed r55407