WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
35535
Web Inspector: render breakpoints as border images instead of canvas.
https://bugs.webkit.org/show_bug.cgi?id=35535
Summary
Web Inspector: render breakpoints as border images instead of canvas.
Pavel Feldman
Reported
2010-03-01 12:31:47 PST
Now that the line number gutter is of variable width, we should support variable width breakpoint images.
Attachments
[IMAGE] Screenshot while running with patch.
(15.47 KB, image/png)
2010-03-01 12:33 PST
,
Pavel Feldman
no flags
Details
[PATCH] Proposed change.
(15.35 KB, patch)
2010-03-01 12:35 PST
,
Pavel Feldman
timothy
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2010-03-01 12:33:28 PST
Created
attachment 49735
[details]
[IMAGE] Screenshot while running with patch.
Pavel Feldman
Comment 2
2010-03-01 12:35:37 PST
Created
attachment 49736
[details]
[PATCH] Proposed change.
Timothy Hatcher
Comment 3
2010-03-01 13:22:31 PST
Comment on
attachment 49736
[details]
[PATCH] Proposed change. You can use -webkit-canvas() as a border-image. But I am fine checking in static images too.
Pavel Feldman
Comment 4
2010-03-02 06:37:50 PST
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebCore/ChangeLog A WebCore/inspector/front-end/Images/breakpointBorder.png A WebCore/inspector/front-end/Images/breakpointConditionalBorder.png A WebCore/inspector/front-end/Images/breakpointConditionalCounterBorder.png A WebCore/inspector/front-end/Images/breakpointCounterBorder.png A WebCore/inspector/front-end/Images/programCounterBorder.png M WebCore/inspector/front-end/SourceFrame.js M WebCore/inspector/front-end/TextViewer.js M WebCore/inspector/front-end/textViewer.css Committed
r55407
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug