Bug 35534 - -[WebArchive initWithCoder:] leaks
Summary: -[WebArchive initWithCoder:] leaks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2010-03-01 11:39 PST by Jim Correia
Modified: 2010-03-04 09:26 PST (History)
2 users (show)

See Also:


Attachments
Don't retain what we don't own. (1.58 KB, patch)
2010-03-04 09:04 PST, Brady Eidson
ggaren: review+
beidson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Correia 2010-03-01 11:39:14 PST
As of r41903, -[WebArchive initWithCoder:] leaks.

It retains the objects decoded from the unarchiver, passes them to another initializer, and never releases them.

This bug was introduced in r31281.
Comment 1 Simon Fraser (smfr) 2010-03-01 11:42:36 PST
http://trac.webkit.org/changeset/31281
Comment 2 Brady Eidson 2010-03-01 11:44:39 PST
<rdar://problem/7702420>
Comment 3 Brady Eidson 2010-03-04 09:04:59 PST
Created attachment 50028 [details]
Don't retain what we don't own.
Comment 4 Geoffrey Garen 2010-03-04 09:11:02 PST
Comment on attachment 50028 [details]
Don't retain what we don't own.

r=me
Comment 5 Brady Eidson 2010-03-04 09:26:01 PST
http://trac.webkit.org/changeset/55529