Bug 35532 - REGRESSION: [view goToBackForwardItem:[[view backForwardList] currentItem]] is broken
Summary: REGRESSION: [view goToBackForwardItem:[[view backForwardList] currentItem]] i...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: InRadar, Regression
Depends on:
Reported: 2010-03-01 11:20 PST by Brady Eidson
Modified: 2010-03-08 12:22 PST (History)
3 users (show)

See Also:

Fix + layouttest (14.35 KB, patch)
2010-03-01 11:55 PST, Brady Eidson
sam: review+
beidson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2010-03-01 11:20:07 PST
The following previously working code is broken:
WebView* view = */ some view /*;
[view goToBackForwardItem:[[view backForwardList] currentItem]];

Telling a Page/FrameLoader to go to the same HistoryItem that is its current HistoryItem is supposed to effectively reload the page. creating a new load and new document.

With the changes to FrameLoader for state objects and certain hash navigations be "same document" navigations, this API started acting as a "same document load"

One concrete example of where this breaks Safari is in the anti-phishing warning, where you can no longer "ignore" an anti-phishing alert.  "http://aboutbillgates.com" is a current example of a site google has flagged as malware and can be used to test this breakage.

The WebCore fix is easy, a layout test requires an API specific addition, and a patch is on its way.
Comment 1 Brady Eidson 2010-03-01 11:20:57 PST
In radar as <rdar://problem/7699371>
Comment 2 Brady Eidson 2010-03-01 11:55:20 PST
Created attachment 49732 [details]
Fix + layouttest
Comment 3 Sam Weinig 2010-03-01 12:54:52 PST
Comment on attachment 49732 [details]
Fix + layouttest

r=me.  Thanks for making a test for this.
Comment 4 Brady Eidson 2010-03-01 13:15:54 PST
Landed in http://trac.webkit.org/changeset/55375
Comment 5 Eric Seidel (no email) 2010-03-05 14:08:40 PST
This new test is broken on windows:

I'm not sure how long it's been broken, but longer than the buildbot can remember. :(
Comment 6 Brady Eidson 2010-03-05 15:02:28 PST
We need to add it to the skipped list I guess, because I won't be able to look at it on windows in the short term.
Comment 7 Eric Seidel (no email) 2010-03-05 15:05:12 PST
rs=me on doing so.
Comment 8 Brady Eidson 2010-03-08 12:22:28 PST
Fixed for reals in r55678