Bug 35532 – REGRESSION: [view goToBackForwardItem:[[view backForwardList] currentItem]] is broken

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Brady Eidson]

The following previously working code is broken:
WebView* view = */ some view /*;
[view goToBackForwardItem:[[view backForwardList] currentItem]];

Telling a Page/FrameLoader to go to the same HistoryItem that is its current HistoryItem is supposed to effectively reload the page. creating a new load and new document.

With the changes to FrameLoader for state objects and certain hash navigations be "same document" navigations, this API started acting as a "same document load"

One concrete example of where this breaks Safari is in the anti-phishing warning, where you can no longer "ignore" an anti-phishing alert.  "http://aboutbillgates.com" is a current example of a site google has flagged as malware and can be used to test this breakage.

The WebCore fix is easy, a layout test requires an API specific addition, and a patch is on its way.

[Brady Eidson]

In radar as <rdar://problem/7699371>

[Brady Eidson]

Created attachment 49732 [details]
Fix + layouttest

[Sam Weinig]

Comment on attachment 49732 [details]
Fix + layouttest

r=me.  Thanks for making a test for this.

[Brady Eidson]

Landed in http://trac.webkit.org/changeset/55375

[Eric Seidel (no email)]

This new test is broken on windows:
http://build.webkit.org/results/Windows%20Debug%20(Tests)/r55554%20(10403)/results.html

I'm not sure how long it's been broken, but longer than the buildbot can remember. :(

[Brady Eidson]

We need to add it to the skipped list I guess, because I won't be able to look at it on windows in the short term.

[Eric Seidel (no email)]

rs=me on doing so.

[Brady Eidson]

Fixed for reals in r55678