Bug 35516 - [Qt] GraphicsLayer: Video element with 3d transform crashes when AC is enabled.
Summary: [Qt] GraphicsLayer: Video element with 3d transform crashes when AC is enabled.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-01 00:30 PST by Kim Grönholm
Modified: 2010-03-02 12:15 PST (History)
3 users (show)

See Also:


Attachments
Video element with 3d transformation (280 bytes, text/html)
2010-03-01 00:30 PST, Kim Grönholm
no flags Details
Prevents the crash. (1.51 KB, patch)
2010-03-01 00:38 PST, Kim Grönholm
no flags Details | Formatted Diff | Diff
Patch for preventing the crash in bug #35516 (1.54 KB, patch)
2010-03-01 02:15 PST, Kim Grönholm
no flags Details | Formatted Diff | Diff
Updated patch for preventing the crash in bug #35516 (1.53 KB, patch)
2010-03-01 04:58 PST, Kim Grönholm
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Grönholm 2010-03-01 00:30:34 PST
Created attachment 49711 [details]
Video element with 3d transformation

The crash happens because GraphicsLayerQt::setContentsToMedia(PlatformLayer* media) gets called with media==NULL. Attached a test page that demonstrates the issue. The crash doesn't happen if ACCELERATED_COMPOSITING is disabled.
Comment 1 Kim Grönholm 2010-03-01 00:38:26 PST
Created attachment 49712 [details]
Prevents the crash.

This patch only prevents the crash without tackling the issue why the 'media'-pointer is NULL.
Comment 2 Noam Rosenthal 2010-03-01 01:37:06 PST
The parameter is null when the compositor wants to cancel the compositing of this video element, and move it back to the regular renderer. we should, in that case, change the content type to HTML and not leave it as video.
Comment 3 Kim Grönholm 2010-03-01 02:15:43 PST
Created attachment 49715 [details]
Patch for preventing the crash in bug #35516

Made the changes Noam requested and submitted a new patch.
Comment 4 Noam Rosenthal 2010-03-01 04:39:29 PST
You should r? cq? it again, if it's complete
Comment 5 WebKit Review Bot 2010-03-01 04:54:36 PST
Attachment 49715 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:857:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Kim Grönholm 2010-03-01 04:58:46 PST
Created attachment 49720 [details]
Updated patch for preventing the crash in bug #35516

Fixed a style issue in the patch.
Comment 7 WebKit Commit Bot 2010-03-02 12:15:34 PST
Comment on attachment 49720 [details]
Updated patch for preventing the crash in bug #35516

Clearing flags on attachment: 49720

Committed r55421: <http://trac.webkit.org/changeset/55421>
Comment 8 WebKit Commit Bot 2010-03-02 12:15:38 PST
All reviewed patches have been landed.  Closing bug.