Bug 35514 – AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

when a grid changes its DOM, and VoiceOver asks for an attribute like AXRows, the children are not updated

[chris fleizach]

Created attachment 49709 [details]
patch

[Darin Adler]

Comment on attachment 49709 [details]
patch

Seems to me that this idiom:

    if (needsToUpdateChildren())
        clearChildren();

    if (!hasChildren())
        addChildren();

Should be in a helper function. It's not good to repeat it all those different places.

Can we make the needsToUpdateChildren protected instead of public?

[chris fleizach]

(In reply to comment #2)
> (From update of attachment 49709 [details])
> Seems to me that this idiom:
> 
>     if (needsToUpdateChildren())
>         clearChildren();
> 
>     if (!hasChildren())
>         addChildren();
> 
> Should be in a helper function. It's not good to repeat it all those different
> places.
> 

Will do

> Can we make the needsToUpdateChildren protected instead of public?

Yes, this patch makes it protected instead of private

[chris fleizach]

http://trac.webkit.org/changeset/55390