Bug 35514 - AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
Summary: AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-28 23:22 PST by chris fleizach
Modified: 2010-03-01 17:19 PST (History)
1 user (show)

See Also:

Attachments
patch (11.91 KB, patch)
2010-03-01 00:03 PST, chris fleizach 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2010-02-28 23:22:12 PST 
when a grid changes its DOM, and VoiceOver asks for an attribute like AXRows, the children are not updated
Comment 1 chris fleizach 2010-03-01 00:03:01 PST 
Created attachment 49709 [details]
patch
Comment 2 Darin Adler 2010-03-01 14:11:32 PST 
Comment on attachment 49709 [details]
patch

Seems to me that this idiom:

    if (needsToUpdateChildren())
        clearChildren();

    if (!hasChildren())
        addChildren();

Should be in a helper function. It's not good to repeat it all those different places.

Can we make the needsToUpdateChildren protected instead of public?
Comment 3 chris fleizach 2010-03-01 14:12:36 PST 
(In reply to comment #2)
> (From update of attachment 49709 [details])
> Seems to me that this idiom:
> 
>     if (needsToUpdateChildren())
>         clearChildren();
> 
>     if (!hasChildren())
>         addChildren();
> 
> Should be in a helper function. It's not good to repeat it all those different
> places.
> 

Will do

> Can we make the needsToUpdateChildren protected instead of public?

Yes, this patch makes it protected instead of private
Comment 4 chris fleizach 2010-03-01 17:19:45 PST 
http://trac.webkit.org/changeset/55390