Bug 35504 – [Gtk] Evaluate and fix AtkTable for layout tables

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

We're now exposing all tables (data and layout) as tables. Before we were only doing so for data tables. The implementation of AtkTable continues to work well for data tables, but not layout tables. At the very least, the number of rows and columns being reported for layout tables is 0. We need to go through our AtkTable implementation for layout tables and get everything working as expected.

[Joanmarie Diggs]

The problem seems to be that all of the nifty accessible table information we get comes from AccessibilityTable. Layout tables are typically rejected as being AccessibilityTables. From what I'm seeing in my sandbox, causing all tables (for Gtk) to be seen as AccessibilityTables solves the reported problem.

That means we just need a bunch of tests. :-) I'll take this one.

(Marking as depends on bug 30895 because until the hierarchy's unborked, we don't want layout tables treated as AccessibilityTables.)

[Joanmarie Diggs]

Created attachment 50158 [details]
Expose layout tables as AccessibilityTables in Gtk

* Exposes layout tables as AccessibilityTables
* Implements rowCount and columnCount for DRT in Gtk
* Includes rowCount and columnCount to the table hierarchy layout test

Note: This patch assumes the second patch for bug 30895. Therefore, not yet marking this for review. But once that patch is committed, this one should be good to go.

Layout tests for table headers will be done as part of bug 30896; layout tests for aspects of the AtkTable implementation will be added as subsequent patches to this bug.

[Joanmarie Diggs]

Comment on attachment 50158 [details]
Expose layout tables as AccessibilityTables in Gtk

Now that the table hierarchy has been unborked.... Setting review? flag.

[Xan Lopez]

Comment on attachment 50158 [details]
Expose layout tables as AccessibilityTables in Gtk

Looks good.

[WebKit Commit Bot]

Comment on attachment 50158 [details]
Expose layout tables as AccessibilityTables in Gtk

Clearing flags on attachment: 50158

Committed r56073: <http://trac.webkit.org/changeset/56073>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.