Bug 35497 - check-webkit-style: Disable most PEP8 checks for webkitpy/thirdparty
Summary: check-webkit-style: Disable most PEP8 checks for webkitpy/thirdparty
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-28 11:44 PST by Chris Jerdonek
Modified: 2010-02-28 21:15 PST (History)
5 users (show)

See Also:

Attachments
Proposed patch (3.52 KB, patch)
2010-02-28 13:18 PST, Chris Jerdonek 		hamaji: review+
cjerdonek: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-02-28 11:44:46 PST 
We may still want to check for things like tabs, carriage returns, and trailing white space.  So perhaps something like the following in the path rules specifier variable:

    (["webkitpy/thirdparty/"],
     ["-",  # Disable all checks but the following.
      "+pep8/W191",  # No tabs.
      "+pep8/W291",  # No trailing white space.
      "+whitespace/carriage_return"]),
Comment 1 Chris Jerdonek 2010-02-28 13:18:16 PST 
Created attachment 49703 [details]
Proposed patch
Comment 2 Shinichiro Hamaji 2010-02-28 20:19:01 PST 
Comment on attachment 49703 [details]
Proposed patch

Nice usage of the path based filter!
Comment 3 Chris Jerdonek 2010-02-28 21:01:01 PST 
(In reply to comment #2)
> (From update of attachment 49703 [details])

Thanks for reviewing!  I suppose I could also have gotten away with just: -pep8, +pep8/W191, +pep8/W291, but this makes the checked categories explicit.
Comment 4 Chris Jerdonek 2010-02-28 21:15:23 PST 
Comment on attachment 49703 [details]
Proposed patch

Manually committed (via "git svn dcommit"):

http://trac.webkit.org/changeset/55360