[chromium] inverted logic in per-strike renderer patch
Created attachment 49699 [details]
I'd like Adam Langley to review this patch. If he's happy, then LGTM.
Also, is there a way to write a layout test for this?
Comment on attachment 49699 [details]
Needs a layout test, or explanation of why a layout test isn't needed or isn't possible.
Am working on Chrome side changes to enable a layout test of this change.
Created attachment 50223 [details]
Comment on attachment 50223 [details]
> +++ b/LayoutTests/fast/text/chromium-linux-fontconfig-renderstyle.html
shouldn't there be some expected results for this test for other platforms?
or should the test be skipped on other platforms? if not, then perhaps the
test should not be named "chromium-linux-*"?
(In reply to comment #7)
> shouldn't there be some expected results for this test for other platforms?
> or should the test be skipped on other platforms? if not, then perhaps the
> test should not be named "chromium-linux-*"?
The Chrome special layout tests seem to have disappeared, and I obviously can't include expected results until the patch is committed. If there's a test-expectations.txt like way to tell the webkit.org builders not to run a given test I'm afraid I don't know it.
(I guess I mostly don't understand your comment, sorry!)
It's suboptimal, but there it is:
$ git ls-files | grep Skipped
I'm not sure how a port-specific layout test is supposed to work.
It looks like LayoutTests/platform/chromium already exists. Can you move the test there and put the expected png and txt file there? It should then be automatically skipped by the other webkit ports.
Created attachment 50506 [details]
Have moved the test into platform/chromium.
I haven't included any expected results partly because --new-baseline is broken (that's a different issue) but mostly because it doesn't make any sense: the results will be different for each platform, so we can't put one set in platform/chromium. Also, our baselines are still carried in our Chromium tree I think.
Comment on attachment 50506 [details]
Clearing flags on attachment: 50506
Committed r56162: <http://trac.webkit.org/changeset/56162>
All reviewed patches have been landed. Closing bug.