WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
35489
Resizing requests are triggered only for uniform content size changes
https://bugs.webkit.org/show_bug.cgi?id=35489
Summary
Resizing requests are triggered only for uniform content size changes
Kalle Vahlman
Reported
2010-02-27 21:47:21 PST
Created
attachment 49693
[details]
Patch to trigger resizes when either of content dimensions change ChromeClient::contentsSizeChanged() currently only triggers resizing if both dimensions change, this is seems obviously wrong.
Attachments
Patch to trigger resizes when either of content dimensions change
(1.36 KB, patch)
2010-02-27 21:47 PST
,
Kalle Vahlman
no flags
Details
Formatted Diff
Diff
Re-made patch to fix (original) style issues
(1.51 KB, patch)
2010-02-27 21:54 PST
,
Kalle Vahlman
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
WebKit Review Bot
Comment 1
2010-02-27 21:51:08 PST
Attachment 49693
[details]
did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:433: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kalle Vahlman
Comment 2
2010-02-27 21:54:50 PST
Created
attachment 49694
[details]
Re-made patch to fix (original) style issues
Gustavo Noronha (kov)
Comment 3
2010-03-01 10:23:49 PST
Comment on
attachment 49694
[details]
Re-made patch to fix (original) style issues Thanks for the patch!
WebKit Commit Bot
Comment 4
2010-03-01 14:07:50 PST
Comment on
attachment 49694
[details]
Re-made patch to fix (original) style issues Clearing flags on attachment: 49694 Committed
r55378
: <
http://trac.webkit.org/changeset/55378
>
WebKit Commit Bot
Comment 5
2010-03-01 14:07:54 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug