Bug 35489 - Resizing requests are triggered only for uniform content size changes
Summary: Resizing requests are triggered only for uniform content size changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-27 21:47 PST by Kalle Vahlman
Modified: 2010-03-01 14:07 PST (History)
2 users (show)

See Also:

Attachments
Patch to trigger resizes when either of content dimensions change (1.36 KB, patch)
2010-02-27 21:47 PST, Kalle Vahlman 		no flags Details | Formatted Diff | Diff
Re-made patch to fix (original) style issues (1.51 KB, patch)
2010-02-27 21:54 PST, Kalle Vahlman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kalle Vahlman 2010-02-27 21:47:21 PST 
Created attachment 49693 [details]
Patch to trigger resizes when either of content dimensions change

ChromeClient::contentsSizeChanged() currently only triggers resizing if both dimensions change, this is seems obviously wrong.
Comment 1 WebKit Review Bot 2010-02-27 21:51:08 PST 
Attachment 49693 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:433:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Kalle Vahlman 2010-02-27 21:54:50 PST 
Created attachment 49694 [details]
Re-made patch to fix (original) style issues
Comment 3 Gustavo Noronha (kov) 2010-03-01 10:23:49 PST 
Comment on attachment 49694 [details]
Re-made patch to fix (original) style issues

Thanks for the patch!
Comment 4 WebKit Commit Bot 2010-03-01 14:07:50 PST 
Comment on attachment 49694 [details]
Re-made patch to fix (original) style issues

Clearing flags on attachment: 49694

Committed r55378: <http://trac.webkit.org/changeset/55378>
Comment 5 WebKit Commit Bot 2010-03-01 14:07:54 PST 
All reviewed patches have been landed.  Closing bug.