RESOLVED FIXED 35464
Fix Chromium's WebKit canaries 
https://bugs.webkit.org/show_bug.cgi?id=35464
Summary Fix Chromium's WebKit canaries
Dumitru Daniliuc
Reported 2010-02-26 17:38:46 PST
Some scripts were moved from WebKitTools/pywebsocket to WebKitTools/Scripts. That broke Chromium's WebKit canaries. In order to fix that, we'd need to update some Chromium scripts. If we do that though, we need to pull in a newer WebCore revision into Chromium, and we can't do that right now, because lots of layout tests are failing. So for now we should add back the relevant script(s) and remove them later once the layout tests pass, a newer WebKit version is pulled into Chromium and Chromium's scripts are updated.
Attachments
patch (1.78 KB, patch)
2010-02-26 17:42 PST, Dumitru Daniliuc 		abarth: review+
dumi: commit-queue-
DetailsFormatted DiffDiff
moving the script to the right location (9.43 KB, patch)
2010-02-26 19:10 PST, Dumitru Daniliuc 		dglazkov: review+
dumi: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dumitru Daniliuc
Comment 1 2010-02-26 17:42:14 PST
Created attachment 49668 [details] patch
Dirk Pranke
Comment 2 2010-02-26 17:43:06 PST
Comment on attachment 49668 [details] patch LGTM
Dirk Pranke
Comment 3 2010-02-26 17:43:29 PST
(In reply to comment #2) > (From update of attachment 49668 [details]) > LGTM I will remove this and update the downstream files once we get past the roll.
Adam Barth
Comment 4 2010-02-26 17:44:04 PST
Comment on attachment 49668 [details] patch ok
Dumitru Daniliuc
Comment 5 2010-02-26 17:54:47 PST
Landed as r55329.
Dumitru Daniliuc
Comment 6 2010-02-26 18:59:10 PST
We put the script in the wrong location.
Dumitru Daniliuc
Comment 7 2010-02-26 19:10:51 PST
Created attachment 49670 [details] moving the script to the right location
Dimitri Glazkov (Google)
Comment 8 2010-02-26 19:23:15 PST
Comment on attachment 49670 [details] moving the script to the right location ok
Dumitru Daniliuc
Comment 9 2010-02-26 19:28:04 PST
Second patch landed as r55336.
Note You need to log in before you can comment on or make changes to this bug.