Bug 35454 - webkit-build could pass unknown arguments to autogen.sh
Summary: webkit-build could pass unknown arguments to autogen.sh
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 35244 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-02-26 14:18 PST by arno.
Modified: 2010-03-01 16:05 PST (History)
5 users (show)

See Also:

Attachments
patch v1 (905 bytes, patch)
2010-02-26 14:22 PST, arno. 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description arno. 2010-02-26 14:18:38 PST 
Hi,
currently, webkit-build parses argument it knows about, and reformats them to pass them to autogen.sh.
But there is no way to pass arguments to autogen.sh if webkit-build does not know about them.
For example, we may want, occasionally, to call autogen.sh with --enable-gtk-doc argument.

Maybe we can just pass unknown arguments to autogen.sh, in the same way qt passes unknown arguments to qmake.
Comment 1 arno. 2010-02-26 14:22:40 PST 
Created attachment 49643 [details]
patch v1
Comment 2 Adam Barth 2010-02-27 01:58:18 PST 
Adding some GTK folks.
Comment 3 Xan Lopez 2010-02-27 02:38:47 PST 
Comment on attachment 49643 [details]
patch v1

Makes sense to me.
Comment 4 Xan Lopez 2010-02-27 02:42:33 PST 
*** Bug 35244 has been marked as a duplicate of this bug. ***
Comment 5 WebKit Commit Bot 2010-03-01 16:05:40 PST 
Comment on attachment 49643 [details]
patch v1

Clearing flags on attachment: 49643

Committed r55384: <http://trac.webkit.org/changeset/55384>
Comment 6 WebKit Commit Bot 2010-03-01 16:05:45 PST 
All reviewed patches have been landed.  Closing bug.