Bug 35449 – Add ability to hide WebFrame scrollbars and to allow scrollbars to overlap with content.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Jing]

Add ability to set whether scrollbars overlap WebFrame document, similar to the overflow: overlay style. Added ability to hide scrollbars on the WebFrame regardless of other scrollbar visibility settings.

[Jing]

Created attachment 49637 [details]
Patch

[Timothy Hatcher]

Comment on attachment 49637 [details]
Patch


> +        frame.size.height = (allowScrollersToOverlapContent ? NSMaxY([[self horizontalScroller] frame]) 
> +                                                                         : NSMinY([[self horizontalScroller] frame]));

> +        frame.size.width = (allowScrollersToOverlapContent ? NSMaxX([[self verticalScroller] frame]) 
> +                                                                        : NSMinX([[self verticalScroller] frame]));

Just put those on one line. You are not saving much space.


> +    [[self window] disableFlushWindow];
> +    [super tile];
> +    [[self contentView] setFrame:[self contentViewFrame]];
> +    [[self window] enableFlushWindow];

I don't think you need disableFlushWindow here. I don't think tile will display and flush.


> +        if (allowScrollersToOverlapContent)
> +            [self setDrawsBackground:NO];

Does this need set back to the previous value if allowScrollersToOverlapContent becomes NO again?

[Jing]

> > +        if (allowScrollersToOverlapContent)
> > +            [self setDrawsBackground:NO];
> 
> Does this need set back to the previous value if allowScrollersToOverlapContent
> becomes NO again?

Nope , drawsBackground gets set else-where before -reflectScrolledClipView is called.

[Jing]

Created attachment 49650 [details]
Patch

Revised according to Tim's comments.

[Jing]

Created attachment 49677 [details]
Move to WebFramePrivate Patch

Moved implementation to WebFramePrivate.

[WebKit Commit Bot]

Comment on attachment 49677 [details]
Move to WebFramePrivate Patch

Clearing flags on attachment: 49677

Committed r55349: <http://trac.webkit.org/changeset/55349>

[WebKit Commit Bot]

Comment on attachment 49637 [details]
Patch

Cleared Timothy Hatcher's review+ from obsolete attachment 49637 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Eric Seidel (no email)]

Does this still need landing, or can it be closed?

[Jing]

It's landed.