Bug 35391 - diff_parser should not log to the root logger
Summary: diff_parser should not log to the root logger
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Jerdonek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-25 09:40 PST by Chris Jerdonek
Modified: 2010-02-26 08:19 PST (History)
6 users (show)

See Also:

Attachments
Proposed patch (1.96 KB, patch)
2010-02-25 09:59 PST, Chris Jerdonek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jerdonek 2010-02-25 09:40:37 PST 
See summary.  See also the similar report for the Python layout test scripts:

https://bugs.webkit.org/show_bug.cgi?id=35194

See the first comment there for more info.
Comment 1 Chris Jerdonek 2010-02-25 09:59:36 PST 
Created attachment 49502 [details]
Proposed patch
Comment 2 Eric Seidel (no email) 2010-02-25 16:00:04 PST 
Comment on attachment 49502 [details]
Proposed patch

LGTM.
Comment 3 Chris Jerdonek 2010-02-25 17:58:18 PST 
(In reply to comment #2)
> (From update of attachment 49502 [details])
> LGTM.

Thanks, Eric!
Comment 4 WebKit Commit Bot 2010-02-26 08:19:49 PST 
Comment on attachment 49502 [details]
Proposed patch

Clearing flags on attachment: 49502

Committed r55284: <http://trac.webkit.org/changeset/55284>
Comment 5 WebKit Commit Bot 2010-02-26 08:19:53 PST 
All reviewed patches have been landed.  Closing bug.