Bug 35379 - Make the context that was passed to the ThreadFunction accessible.
Summary: Make the context that was passed to the ThreadFunction accessible.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-25 04:59 PST by jochen
Modified: 2010-02-25 06:49 PST (History)
2 users (show)

See Also:

Attachments
Patch (7.37 KB, patch)
2010-02-25 05:03 PST, jochen 		no flags Details | Formatted Diff | Diff
patch (7.37 KB, patch)
2010-02-25 05:50 PST, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2010-02-25 04:59:37 PST 
Make the context that was passed to the ThreadFunction accessible.
Comment 1 jochen 2010-02-25 05:03:55 PST 
Created attachment 49477 [details]
Patch
Comment 2 jochen 2010-02-25 05:08:47 PST 
I can't think of any way to test this using a layout test
Comment 3 Jeremy Orlow 2010-02-25 05:34:27 PST 
Comment on attachment 49477 [details]
Patch

r=me but because there are nits to fix, cq=-

> --- a/JavaScriptCore/wtf/ThreadingPthreads.cpp
> +++ b/JavaScriptCore/wtf/ThreadingPthreads.cpp
> @@ -53,7 +53,13 @@
>  
>  namespace WTF {
>  
> -typedef HashMap<ThreadIdentifier, pthread_t> ThreadMap;
> +typedef struct {
> +    pthread_t handle;
> +    void* context;
> +} ThreadInfo;
> +

extra new line

> +
> +typedef HashMap<ThreadIdentifier, ThreadInfo> ThreadMap;
>  
>  static Mutex* atomicallyInitializedStaticMutex;
>
Comment 4 jochen 2010-02-25 05:50:02 PST 
Created attachment 49481 [details]
patch
Comment 5 WebKit Commit Bot 2010-02-25 06:49:18 PST 
Comment on attachment 49481 [details]
patch

Clearing flags on attachment: 49481

Committed r55234: <http://trac.webkit.org/changeset/55234>
Comment 6 WebKit Commit Bot 2010-02-25 06:49:23 PST 
All reviewed patches have been landed.  Closing bug.