1. Open some HTML page with inline script 2. Stop on breakpoint inside that script 3. Hover over elements to see evaluated results Expected: popover with result Actual: nothing happens The reason is that evaluate-on-hover works for highlighted source only, so we need to highlight inner JavaScript to make it work.
Created attachment 49474 [details] [PATCH] Proposed change. This change also removes editing-related complexities from the highlighter logic.
Created attachment 49476 [details] [PATCH] Proposed change. (Same with updated expectations for HTML test)
Attachment 49476 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/inspector/front-end/SourceHTMLTokenizer.js:143: Line contains tab character. [whitespace/tab] [5] WebCore/inspector/front-end/SourceHTMLTokenizer.js:144: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 49476 [details] [PATCH] Proposed change. (Same with updated expectations for HTML test) > + var match = /<\/[Ss][Cc][Rr][Ii][Pp][Tt]/.exec(line); Why not just do //i?
(In reply to comment #4) > (From update of attachment 49476 [details]) > > + var match = /<\/[Ss][Cc][Rr][Ii][Pp][Tt]/.exec(line); > > Why not just do //i? Fixed.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/syntax-highlight-html-expected.txt M WebCore/ChangeLog M WebCore/inspector/front-end/SourceCSSTokenizer.js M WebCore/inspector/front-end/SourceCSSTokenizer.re2js M WebCore/inspector/front-end/SourceHTMLTokenizer.js M WebCore/inspector/front-end/SourceHTMLTokenizer.re2js M WebCore/inspector/front-end/SourceJavaScriptTokenizer.js M WebCore/inspector/front-end/SourceJavaScriptTokenizer.re2js M WebCore/inspector/front-end/SourceTokenizer.js M WebCore/inspector/front-end/TextEditorHighlighter.js M WebCore/inspector/front-end/TextViewer.js Committed r55248