Bug 35365 - WebKitTools/Scripts/webkitpy/layout_package functions have inconsistent "actual, expected" ordering in arguments
Summary: WebKitTools/Scripts/webkitpy/layout_package functions have inconsistent "actu...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 35265
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-24 15:12 PST by Eric Seidel (no email)
Modified: 2010-02-24 15:12 PST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-02-24 15:12:24 PST
WebKitTools/Scripts/webkitpy/layout_package functions have inconsistent "actual, expected" ordering in arguments

Many functions expect "actual, expect", others expect "expected, actual".  This is super-confusing and causes bugs like bug 35265.

We need to go through and standardize.  My vote would be that we standardize on "expected, actual" since that matches the expected diff output order.