Bug 35354 - SVG's tspan is no member of SVGRenderBase, this can cause crashes on filters
Summary: SVG's tspan is no member of SVGRenderBase, this can cause crashes on filters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-24 12:43 PST by Dirk Schulze
Modified: 2010-02-25 15:04 PST (History)
1 user (show)

See Also:

Attachments
get bounding box for tspan (25.54 KB, patch)
2010-02-24 13:14 PST, Dirk Schulze 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2010-02-24 12:43:38 PST 
SVG's tspan is no member of SVGRenderBase, this can cause crashes on filters. Another problem is, that childs of text elements don't have a boundingBox or repaintRect. So we can't use clipping masking and some other resources on tspan's.
Comment 1 Dirk Schulze 2010-02-24 13:14:47 PST 
Created attachment 49425 [details]
get bounding box for tspan

get bounding boxes for tspan and inline texts. We take the bounding boxes of the text root. We also need to take the repaint rect of text root to get the right results in filters. Mainly because of chapter 10.4 in the  SVG spec.
Comment 2 Nikolas Zimmermann 2010-02-25 13:36:29 PST 
Comment on attachment 49425 [details]
get bounding box for tspan

Great, r=me.
Comment 3 Dirk Schulze 2010-02-25 15:04:35 PST 
Comment on attachment 49425 [details]
get bounding box for tspan

Clearing flags on attachment: 49425

Committed r55260: <http://trac.webkit.org/changeset/55260>
Comment 4 Dirk Schulze 2010-02-25 15:04:44 PST 
All reviewed patches have been landed.  Closing bug.