Bug 35345 - [chromium] Should be possible to compile V8 bindings without SVG support
Summary: [chromium] Should be possible to compile V8 bindings without SVG support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-24 08:24 PST by Dominic Mazzoni
Modified: 2010-02-24 20:43 PST (History)
3 users (show)

See Also:

Attachments
Patch to wrap includes of svg headers. (6.89 KB, patch)
2010-02-24 08:38 PST, Dominic Mazzoni 		no flags Details | Formatted Diff | Diff
Updated patch without whitespace changes. (5.13 KB, patch)
2010-02-24 08:44 PST, Dominic Mazzoni 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Mazzoni 2010-02-24 08:24:26 PST 
This patch wraps includes of SVG headers so that it's possible to compile the V8 bindings with SVG disabled, e.g. 'enable_svg=0'.
Comment 1 Dominic Mazzoni 2010-02-24 08:38:18 PST 
Created attachment 49398 [details]
Patch to wrap includes of svg headers.
Comment 2 Evan Martin 2010-02-24 08:40:11 PST 
WebKit style frowns on whitespace edits (in the copyrights).
Comment 3 Dominic Mazzoni 2010-02-24 08:44:28 PST 
Created attachment 49400 [details]
Updated patch without whitespace changes.
Comment 4 Evan Martin 2010-02-24 08:47:53 PST 
LGTM, thanks for fixing it (need a real reviewer to review it tho)
Comment 5 Jeremy Orlow 2010-02-24 09:10:35 PST 
r=me
Comment 6 WebKit Commit Bot 2010-02-24 20:43:26 PST 
Comment on attachment 49400 [details]
Updated patch without whitespace changes.

Clearing flags on attachment: 49400

Committed r55217: <http://trac.webkit.org/changeset/55217>
Comment 7 WebKit Commit Bot 2010-02-24 20:43:31 PST 
All reviewed patches have been landed.  Closing bug.