RESOLVED FIXED Bug 35345
[chromium] Should be possible to compile V8 bindings without SVG support 
https://bugs.webkit.org/show_bug.cgi?id=35345
Summary [chromium] Should be possible to compile V8 bindings without SVG support
Dominic Mazzoni
Reported 2010-02-24 08:24:26 PST
This patch wraps includes of SVG headers so that it's possible to compile the V8 bindings with SVG disabled, e.g. 'enable_svg=0'.
Attachments
Patch to wrap includes of svg headers. (6.89 KB, patch)
2010-02-24 08:38 PST, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
Updated patch without whitespace changes. (5.13 KB, patch)
2010-02-24 08:44 PST, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dominic Mazzoni
Comment 1 2010-02-24 08:38:18 PST
Created attachment 49398 [details] Patch to wrap includes of svg headers.
Evan Martin
Comment 2 2010-02-24 08:40:11 PST
WebKit style frowns on whitespace edits (in the copyrights).
Dominic Mazzoni
Comment 3 2010-02-24 08:44:28 PST
Created attachment 49400 [details] Updated patch without whitespace changes.
Evan Martin
Comment 4 2010-02-24 08:47:53 PST
LGTM, thanks for fixing it (need a real reviewer to review it tho)
Jeremy Orlow
Comment 5 2010-02-24 09:10:35 PST
r=me
WebKit Commit Bot
Comment 6 2010-02-24 20:43:26 PST
Comment on attachment 49400 [details] Updated patch without whitespace changes. Clearing flags on attachment: 49400 Committed r55217: <http://trac.webkit.org/changeset/55217>
WebKit Commit Bot
Comment 7 2010-02-24 20:43:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.