Bug 35267 - [Qt] Faster cut-off for rectangle drawing without shadow
Summary: [Qt] Faster cut-off for rectangle drawing without shadow
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Ariya Hidayat
Keywords: Qt
Depends on:
Reported: 2010-02-22 15:44 PST by Ariya Hidayat
Modified: 2010-02-23 06:17 PST (History)
0 users

See Also:

patch (1.86 KB, patch)
2010-02-22 18:08 PST, Ariya Hidayat
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ariya Hidayat 2010-02-22 15:44:16 PST
GraphicsContext::drawRect always checks and allocates some local variables for the shadow properties. Since most of the cases, we have rectangle drawing without shadow, we should have a faster code path for the common case.

Will upload a patch.
Comment 1 Ariya Hidayat 2010-02-22 18:08:16 PST
Created attachment 49251 [details]
Comment 2 Ariya Hidayat 2010-02-23 06:17:46 PST
Comment on attachment 49251 [details]

Clearing flags on attachment: 49251

Committed r55148: <http://trac.webkit.org/changeset/55148>
Comment 3 Ariya Hidayat 2010-02-23 06:17:51 PST
All reviewed patches have been landed.  Closing bug.