Bug 35262 – Create a copy of the HTMLCanvasElement files.

• Status: RESOLVED
• Resolution: INVALID
• Component: DOM

[David Levin]

This will be a CanvasSurface class which does the majority of the common work for HTMLCanvasElement and OffscreenCanvas.

[David Levin]

Created attachment 49244 [details]
Proposed fix.

[David Levin]

Created attachment 49329 [details]
Proposed fix.

[Oliver Hunt]

Comment on attachment 49329 [details]
Proposed fix.

I think a better first step would be to create a CanvasSurface class and make HTMLCanvasElement inherit from that, then in a follow up patch move the shared functionality down to CanvasSurface

[WebKit Review Bot]

Attachment 49329 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/dom/CanvasSurface.cpp:28:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebCore/dom/CanvasSurface.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/dom/CanvasSurface.cpp:174:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebCore/dom/CanvasSurface.cpp:321:  Use 0 instead of NULL.  [readability/null] [4]
WebCore/dom/CanvasSurface.h:27:  #ifndef header guard has wrong style, please use: CanvasSurface_h  [build/header_guard] [5]
WebCore/dom/CanvasSurface.h:140:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 6 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Levin]

Comment on attachment 49329 [details]
Proposed fix.

r- per Oliver's feedback.